From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS
 commands support
Date: Mon, 29 Jun 2015 13:23:30 +0100
Message-ID: <1435580610.32500.302.camel@citrix.com>
References: <1434974517-12136-1-git-send-email-vijay.kilari@gmail.com>
	<1434974517-12136-10-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1434974517-12136-10-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com
Cc: stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, tim@xen.org, xen-devel@lists.xen.org, julien.grall@citrix.com, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-06-22 at 17:31 +0530, vijay.kilari@gmail.com wrote:
> +static int vgic_its_process_mapvi(struct vcpu *v, struct vgic_its *vits,
> +                                  its_cmd_block *virt_cmd)
> +{
> +    struct vitt entry;
> +    struct vits_device *vdev;
> +    uint8_t vcol_id, cmd;
> +    uint32_t vid, dev_id, event;
> +
> +    vcol_id = virt_cmd->mapvi.col;
> +    vid = virt_cmd->mapvi.phy_id;
> +    dev_id = its_decode_devid(v->domain, virt_cmd);

If you used the "union its_cmd" I proposed earlier for the virt_cmd
argument then this would just be "virt_command->mapvi.devid".

[...]

> +static int vgic_its_parse_its_command(struct vcpu *v, struct vgic_its *vits,
> +                                      its_cmd_block *virt_cmd)
> +{
> +    uint8_t cmd = its_decode_cmd(virt_cmd);

and this would be cirt_cmd->hdr.cmd.

[...]
> +    memcpy(virt_cmd, p + offset, sizeof(its_cmd_block));

and this would be
	memcpy(&virt_cmd.bits[0], p+offset, sizeof(union its_cmd));

Ian.