From: Ian Campbell <ian.campbell@citrix.com>
To: Chong Li <lichong659@gmail.com>
Cc: Chong Li <chong.li@wustl.edu>, Wei Liu <wei.liu2@citrix.com>,
Sisu Xi <xisisu@gmail.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
"dario.faggioli" <dario.faggioli@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel <xen-devel@lists.xen.org>,
Meng Xu <mengxu@cis.upenn.edu>,
Dagaen Golomb <dgolomb@seas.upenn.edu>
Subject: Re: [PATCH v3 for Xen 4.6 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler
Date: Tue, 30 Jun 2015 16:57:17 +0100 [thread overview]
Message-ID: <1435679837.21469.218.camel@citrix.com> (raw)
In-Reply-To: <CAGHO-ipR5A_Uqwf-vHLZOMbX99GpVbc=cw24uDkB+fUEKTv07Q@mail.gmail.com>
On Tue, 2015-06-30 at 10:42 -0500, Chong Li wrote:
> >> @@ -1554,10 +1564,17 @@ int libxl_sched_credit_params_set(libxl_ctx *ctx, uint32_t poolid,
> >> #define LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT -1
> >> #define LIBXL_DOMAIN_SCHED_PARAM_BUDGET_DEFAULT -1
> >>
> >> +/* Per-VCPU parameters*/
> >> +#define LIBXL_DOMAIN_SCHED_PARAM_VCPU_INDEX_DEFAULT -1
> >
> > What is the effect of passing vcpuid == -1 to this interface?
>
> I think the right way should be:
>
> #define LIBXL_SCHED_PARAM_VCPU_INDEX_DEFAULT -1
>
> which is the default value for the vcpuid in libxl_sched_params. Even
> though libxl_sched_params is used for per-vcpu settings, all the other
> fields (except vcpuid) would still use
> LIBXL_DOMAIN_SCHED_PARAM_*_DEFAULT values, just for convenience.
My question is what does the concept of vcpu==-1 mean in this interface?
Ian.
next prev parent reply other threads:[~2015-06-30 15:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 2:44 [PATCH v3 for Xen 4.6 0/4] Enable per-VCPU parameter settings for RTDS scheduler Chong Li
2015-06-29 2:44 ` [PATCH v3 for Xen 4.6 1/4] xen: enable " Chong Li
2015-07-07 8:59 ` Jan Beulich
2015-07-07 14:39 ` Dario Faggioli
2015-07-08 6:06 ` Meng Xu
2015-07-08 8:33 ` Dario Faggioli
2015-07-09 1:16 ` Meng Xu
2015-07-10 9:51 ` Dario Faggioli
2015-07-07 14:55 ` Dario Faggioli
2015-07-07 16:09 ` Jan Beulich
2015-07-07 15:33 ` Chong Li
2015-07-07 15:41 ` Jan Beulich
2015-07-07 15:46 ` Dario Faggioli
2015-07-07 14:51 ` Dario Faggioli
2015-06-29 2:44 ` [PATCH v3 for Xen 4.6 2/4] libxc: " Chong Li
2015-06-30 12:22 ` Ian Campbell
2015-06-30 15:18 ` Chong Li
2015-06-30 15:32 ` Ian Campbell
2015-06-30 15:57 ` Chong Li
2015-06-30 16:04 ` Ian Campbell
2015-06-29 2:44 ` [PATCH v3 for Xen 4.6 3/4] libxl: " Chong Li
2015-06-30 12:26 ` Ian Campbell
2015-06-30 15:42 ` Chong Li
2015-06-30 15:57 ` Ian Campbell [this message]
2015-06-30 16:10 ` Chong Li
2015-06-30 16:19 ` Ian Campbell
2015-06-30 16:53 ` Chong Li
2015-07-01 0:54 ` Meng Xu
2015-07-01 8:48 ` Ian Campbell
2015-07-01 12:50 ` Dario Faggioli
2015-07-01 16:59 ` Chong Li
2015-07-07 16:23 ` Dario Faggioli
2015-07-08 14:35 ` Chong Li
2015-07-08 14:45 ` Dario Faggioli
2015-06-29 2:44 ` [PATCH v3 for Xen 4.6 4/4] xl: " Chong Li
2015-07-07 15:34 ` Dario Faggioli
2015-07-07 16:01 ` Chong Li
2015-07-07 15:16 ` [PATCH v3 for Xen 4.6 0/4] Enable " Dario Faggioli
2015-07-07 16:11 ` Chong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435679837.21469.218.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=chong.li@wustl.edu \
--cc=dario.faggioli@citrix.com \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=mengxu@cis.upenn.edu \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xisisu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).