From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3 COLOPre 15/26] tools/libxl: Add back
 channel to allow migration target send data back
Date: Wed, 1 Jul 2015 11:40:10 +0100
Message-ID: <1435747210.21469.250.camel@citrix.com>
References: <1435213552-10556-1-git-send-email-yanghy@cn.fujitsu.com>
	<1435213552-10556-16-git-send-email-yanghy@cn.fujitsu.com>
	<1435658826.21469.66.camel@citrix.com> <55935057.10403@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55935057.10403@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-07-01 at 10:28 +0800, Yang Hongyang wrote:
> 
> On 06/30/2015 06:07 PM, Ian Campbell wrote:
> > On Thu, 2015-06-25 at 14:25 +0800, Yang Hongyang wrote:
> >> + * LIBXL_HAVE_DOMAIN_CREATE_RESTORE_SEND_FD 1
> >> + *
> >> + * If this is defined, libxl_domain_create_restore()'s API has changed to
> >> + * include a send_fd param which used for libxl migration back channel.
> >
> >                                     ^is
> >
> > Perhaps also end the sentence with "during $foo operations"? Since it is
> > not used for standard restore.
> 
> IIRC, at hackthon, someone from alibaba also mentioned that they need a back
> channel on normal migration

There is no code like that in tree, if such is added then comments may
need to be adjusted.

> ...For the standard restore, just pass -1 as
> send_fd.

Correct.

I'm asking for a clarification to thew comment here, not a code change.

> 
> >
> >>   int libxl_domain_create_restore(libxl_ctx *ctx, libxl_domain_config *d_config,
> >> -                                uint32_t *domid, int restore_fd,
> >> +                                uint32_t *domid, int restore_fd, int send_fd,
> >
> > This is probably not a good idea, but what about "int fd[2]", i.e.
> > mimicking pipe(2). I suspect this will just make things harder on
> 
> I suspect so...
> 
> > callers, especially those who wish to work with both versions. Thoughts?
> >
> > Ian.
> >
> > .
> >
>