From: Jennifer Herbert <Jennifer.Herbert@citrix.com>
To: xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com,
	ian.campbell@citrix.com,
	Jennifer Herbert <jennifer.herbert@citrix.com>,
	stefano.stabellini@eu.citrix.com
Subject: [PATCH 7/7] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()
Date: Wed, 1 Jul 2015 17:37:12 +0000	[thread overview]
Message-ID: <1435772232-39085-8-git-send-email-Jennifer.Herbert@citrix.com> (raw)
In-Reply-To: <1435772232-39085-1-git-send-email-Jennifer.Herbert@citrix.com>
Unlikely that it may seem localtime_r could fail, which would result in a
null pointer dereference.  In this case, one can simply just skip logging the
date/time, and logging anything is more useful then nothing.
Signed-off-by: Jennifer Herbert <jennifer.herbert@citrix.com>
---
 tools/libxc/xtl_logger_stdio.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/libxc/xtl_logger_stdio.c b/tools/libxc/xtl_logger_stdio.c
index d8646e0..74d66a5 100644
--- a/tools/libxc/xtl_logger_stdio.c
+++ b/tools/libxc/xtl_logger_stdio.c
@@ -61,10 +61,11 @@ static void stdiostream_vmessage(xentoollog_logger *logger_in,
         struct tm lt_buf;
         time_t now = time(0);
         struct tm *lt= localtime_r(&now, <_buf);
-        fprintf(lg->f, "%04d-%02d-%02d %02d:%02d:%02d %s ",
-                lt->tm_year+1900, lt->tm_mon+1, lt->tm_mday,
-                lt->tm_hour, lt->tm_min, lt->tm_sec,
-                tzname[!!lt->tm_isdst]);
+        if (lt != NULL)
+            fprintf(lg->f, "%04d-%02d-%02d %02d:%02d:%02d %s ",
+                    lt->tm_year+1900, lt->tm_mon+1, lt->tm_mday,
+                    lt->tm_hour, lt->tm_min, lt->tm_sec,
+                    tzname[!!lt->tm_isdst]);
     }
     if (lg->flags & XTL_STDIOSTREAM_SHOW_PID)
         fprintf(lg->f, "[%lu] ", (unsigned long)getpid());
-- 
1.7.10.4
next prev parent reply	other threads:[~2015-07-01 17:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 17:37 [PATCH 0/7] libxc: Fix a number of coverity issues Jennifer Herbert
2015-07-01 17:37 ` [PATCH 1/7] libxc: fix uninitialized variable in xc_cpuid_pv_policy() Jennifer Herbert
2015-07-02 13:19   ` Andrew Cooper
2015-07-03 14:39   ` Andrew Cooper
2015-07-03 15:15   ` Ian Jackson
2015-07-03 15:39     ` Ian Campbell
2015-07-03 15:47       ` Ian Jackson
2015-07-03 15:50         ` Ian Campbell
2015-07-03 15:57           ` Andrew Cooper
2015-07-01 17:37 ` [PATCH 2/7] libxc: Use const pointer in local_file_dump() Jennifer Herbert
2015-07-03 15:27   ` Ian Jackson
2015-07-07 12:16     ` Jennifer Herbert
2015-07-07 12:15       ` Ian Jackson
2015-07-01 17:37 ` [PATCH 3/7] libxc: Fix uninitialized valiables in xc_cpuid_hvm_policy() Jennifer Herbert
2015-07-03 15:30   ` Ian Jackson
2015-07-01 17:37 ` [PATCH 4/7] libxc: Prevent dereferencing NULL pointers returned from xc_dom_allocate() Jennifer Herbert
2015-07-03 15:17   ` Ian Jackson
2015-07-03 16:01     ` Ian Campbell
2015-07-01 17:37 ` [PATCH 5/7] libxc: Removing dead code " Jennifer Herbert
2015-07-03 14:41   ` Andrew Cooper
2015-07-03 15:24   ` Ian Jackson
2015-07-03 15:31     ` Ian Campbell
2015-07-03 15:33       ` Ian Jackson
2015-07-03 15:46         ` Ian Campbell
2015-07-03 15:48           ` Ian Jackson
2015-07-01 17:37 ` [PATCH 6/7] libxc: Fix misleading use of strncpy code in build_hvm_info() Jennifer Herbert
2015-07-03 14:41   ` Andrew Cooper
2015-07-03 15:25   ` Ian Jackson
2015-07-03 16:01     ` Ian Campbell
2015-07-01 17:37 ` Jennifer Herbert [this message]
2015-07-03 15:29   ` [PATCH 7/7] libxc: Prevent NULL pointer dereference in stdiostream_vmessage() Ian Jackson
2015-07-03 15:37     ` Ian Campbell
2015-07-03 15:44       ` Ian Jackson
2015-07-02 13:23 ` [PATCH 0/7] libxc: Fix a number of coverity issues Andrew Cooper
2015-07-03 14:21   ` Ian Campbell
2015-07-03 14:20 ` Ian Campbell
2015-07-03 14:22   ` Andrew Cooper
2015-07-03 14:42     ` Ian Campbell
2015-07-03 14:49       ` Andrew Cooper
2015-07-03 15:13 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=1435772232-39085-8-git-send-email-Jennifer.Herbert@citrix.com \
    --to=jennifer.herbert@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).