From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 4/4] ts-logs-capture: Run xenctx earlier Date: Fri, 3 Jul 2015 09:55:41 +0100 Message-ID: <1435913741.9447.19.camel@citrix.com> References: <1435857067-10704-1-git-send-email-ian.jackson@eu.citrix.com> <1435857067-10704-5-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAwl8-0000pX-6B for xen-devel@lists.xenproject.org; Fri, 03 Jul 2015 08:55:46 +0000 In-Reply-To: <1435857067-10704-5-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-07-02 at 18:11 +0100, Ian Jackson wrote: > Break fetch_xenctx_guest out into its own function, and run it before > serial_fetch_logs. > > This is relevant because serial_fetch_logs sends the Xen debug keys, > which might dislodge a stuck guest - and, if it does, we would like to > have captured the stuck state with xenctx, rather than the unstuck > one. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell At first I wondered if before and after might be useful, but I don't think the unstuck state would be useful. However two (or more) back-to-back ctxt's can often be useful, by giving a snapshot of the loop the guest is stuck. Ian.