From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org,
Dario Faggioli <dario.faggioli@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 1/2] libxl: turn NUMA placement misconfigs into warnings
Date: Fri, 3 Jul 2015 11:35:23 +0100 [thread overview]
Message-ID: <1435919723.9447.72.camel@citrix.com> (raw)
In-Reply-To: <21907.64386.480660.370761@mariner.uk.xensource.com>
On Wed, 2015-07-01 at 15:38 +0100, Ian Jackson wrote:
> Dario Faggioli writes ("[PATCH 1/2] libxl: turn NUMA placement misconfigs into warnings"):
> > instead than errors. More specifically, in libxl,
> > b_info->numa_autoplacement is meant as a way to
> > disable automatic NUMA placement, if one does not
> > want it to happen. It is, however, useful for
> > consistency checking as well, i.e., to ensure that
> > the user provided configuration (such as, for instance,
> > vcpu hard or soft affinity) and NUMA placement itself
> > will not clash.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Applied both patches with your ack.
> But, be aware that you are making a semantic change to the API which
> cannot be reverted for backwards-compatibility reasons.
Is any further action required due to this?
next prev parent reply other threads:[~2015-07-03 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 14:02 [PATCH 0/2] libxl: fix NUMA placement preventing domain config to be re-used Dario Faggioli
2015-07-01 14:03 ` [PATCH 1/2] libxl: turn NUMA placement misconfigs into warnings Dario Faggioli
2015-07-01 14:38 ` Ian Jackson
2015-07-03 10:35 ` Ian Campbell [this message]
2015-07-03 11:09 ` Ian Jackson
2015-07-03 14:52 ` Dario Faggioli
2015-07-01 14:03 ` [PATCH 2/2] libxl: unset info->numa_placement upon successful placement Dario Faggioli
2015-07-01 14:39 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435919723.9447.72.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).