From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 1/2] libxl: turn NUMA placement misconfigs into warnings Date: Fri, 3 Jul 2015 11:35:23 +0100 Message-ID: <1435919723.9447.72.camel@citrix.com> References: <20150701135059.15951.39938.stgit@Solace.station> <20150701140306.15951.83934.stgit@Solace.station> <21907.64386.480660.370761@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAyJk-0006UO-1V for xen-devel@lists.xenproject.org; Fri, 03 Jul 2015 10:35:36 +0000 In-Reply-To: <21907.64386.480660.370761@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Dario Faggioli , Wei Liu , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Wed, 2015-07-01 at 15:38 +0100, Ian Jackson wrote: > Dario Faggioli writes ("[PATCH 1/2] libxl: turn NUMA placement misconfigs into warnings"): > > instead than errors. More specifically, in libxl, > > b_info->numa_autoplacement is meant as a way to > > disable automatic NUMA placement, if one does not > > want it to happen. It is, however, useful for > > consistency checking as well, i.e., to ensure that > > the user provided configuration (such as, for instance, > > vcpu hard or soft affinity) and NUMA placement itself > > will not clash. > > Acked-by: Ian Jackson Applied both patches with your ack. > But, be aware that you are making a semantic change to the API which > cannot be reverted for backwards-compatibility reasons. Is any further action required due to this?