From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: julien.grall@citrix.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v5 1/6] xen: dt: add dt_for_each_irq_map helper
Date: Fri, 3 Jul 2015 15:18:11 +0100 [thread overview]
Message-ID: <1435933091.9447.124.camel@citrix.com> (raw)
In-Reply-To: <1435931957-26227-1-git-send-email-ian.campbell@citrix.com>
On Fri, 2015-07-03 at 14:59 +0100, Ian Campbell wrote:
> This function iterates over a nodes interrupt-map property and calls a
> callback for each interrupt. For now it only supplies the translated
> IRQ since my use case has no need of e.g. child unit address. These
> can be added as needed by any future users.
>
> This follows much the same logic as dt_irq_map_raw when parsing the
> interrupt-map, but doesn't walk up the tree doing the actual
> translation and it iterates over all entries instead of just looking
> for the first match.
>
> I looked into refactoring dt_irq_map_raw but I couldn't find a way
> which I was confident in, plus I was reluctant to diverge from the
> Linux roots of this function any further.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Reviewed-by: Julien Grall <julien.grall@citrix.com>
Julien pointed out that after this R-by response on v4 there was also a
bunch of comments which I had missed (i.e. the R-by was a typo). I've
replied to those on v4.
(Mostly responding here for my own benefit so I don't go and commit it
at some point).
next prev parent reply other threads:[~2015-07-03 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 13:59 [PATCH v5 0/6] xen: arm: Parse PCI DT nodes' ranges and interrupt-map Ian Campbell
2015-07-03 13:59 ` [PATCH v5 1/6] xen: dt: add dt_for_each_irq_map helper Ian Campbell
2015-07-03 14:18 ` Ian Campbell [this message]
2015-07-03 13:59 ` [PATCH v5 2/6] xen: dt: add dt_for_each_range helper Ian Campbell
2015-07-03 13:59 ` [PATCH v5 3/6] xen: arm: drop redundant extra call to vgic_reserve_virq Ian Campbell
2015-07-03 13:59 ` [PATCH v5 4/6] xen: arm: map child MMIO and IRQs to dom0 for PCI bus DT nodes Ian Campbell
2015-07-03 13:59 ` [PATCH v5 5/6] xen: arm: Import of_bus PCI entry from Linux (as a dt_bus entry) Ian Campbell
2015-07-03 13:59 ` [PATCH v5 6/6] xen: arm: consolidate mmio and irq mapping to dom0 Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435933091.9447.124.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).