From: Ian Campbell <ian.campbell@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Rob Hoes <Rob.Hoes@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v2 1/7] libxl: get rid of the SEDF scheduler
Date: Fri, 3 Jul 2015 15:39:30 +0100 [thread overview]
Message-ID: <1435934370.9447.142.camel@citrix.com> (raw)
In-Reply-To: <1435934006.14347.75.camel@citrix.com>
On Fri, 2015-07-03 at 16:33 +0200, Dario Faggioli wrote:
> On Fri, 2015-07-03 at 15:23 +0100, Ian Campbell wrote:
> > On Fri, 2015-07-03 at 12:24 +0200, Dario Faggioli wrote:
> >
> > > @@ -5932,7 +5865,8 @@ int libxl_domain_sched_params_set(libxl_ctx *ctx, uint32_t domid,
> > >
> > > switch (sched) {
> > > case LIBXL_SCHEDULER_SEDF:
> > > - ret=sched_sedf_domain_set(gc, domid, scinfo);
> > > + LOG(ERROR, "SEDF scheduler no longer available");
> > > + ret=ERROR_INVAL;
> >
> > Should we have a specific error code for removed functionality?
> >
> Good point: shall I introduce it? If yes, how should it be called?
>
> ERROR_REMOVED
> ERROR_DEPRECATED
> ERROR_GONE
>
> I think I'd go for _REMOVED, as deprecated suggests (to me at least)
> that it's still there but nshould not be used.
REMOVED > DEPRECATED > GONE IMHO too.
> Any other ideas?
Not here, maybe someone on the cc has an opinion. In particular Ian has
been looking at error codes with Rob Hoes recent patches, maybe one of
them has some thoughts.
Ian.
next prev parent reply other threads:[~2015-07-03 14:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 10:24 [PATCH v2 0/7] get rid of the SEDF scheduler Dario Faggioli
2015-07-03 10:24 ` [PATCH v2 1/7] libxl: " Dario Faggioli
2015-07-03 14:23 ` Ian Campbell
2015-07-03 14:33 ` Dario Faggioli
2015-07-03 14:39 ` Ian Campbell [this message]
2015-07-03 14:50 ` Ian Jackson
2015-07-03 14:49 ` Ian Jackson
2015-07-03 10:24 ` [PATCH v2 2/7] tools: python: get rid of the SEDF scheduler bindings Dario Faggioli
2015-07-03 14:23 ` Ian Campbell
2015-07-03 10:24 ` [PATCH v2 3/7] libxc: get rid of the SEDF scheduler Dario Faggioli
2015-07-03 14:23 ` Ian Campbell
2015-07-03 10:25 ` [PATCH v2 4/7] xen: " Dario Faggioli
2015-07-03 10:30 ` Andrew Cooper
2015-07-03 13:26 ` Dario Faggioli
2015-07-03 10:25 ` [PATCH v2 5/7] xen: kill sched_sedf.c Dario Faggioli
2015-07-03 10:25 ` [PATCH v2 6/7] xl: get rid of the SEDF scheduler Dario Faggioli
2015-07-03 14:26 ` Ian Campbell
2015-07-03 14:36 ` Dario Faggioli
2015-07-03 14:42 ` Ian Campbell
2015-07-03 10:25 ` [PATCH v2 7/7] docs: " Dario Faggioli
2015-07-03 14:26 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435934370.9447.142.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Rob.Hoes@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).