From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 1/7] libxl: get rid of the SEDF scheduler
Date: Fri, 3 Jul 2015 15:39:30 +0100
Message-ID: <1435934370.9447.142.camel@citrix.com>
References: <20150703101558.5144.46511.stgit@Solace.station>
	<20150703102438.5144.35293.stgit@Solace.station>
	<1435933382.9447.127.camel@citrix.com>
	<1435934006.14347.75.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6194caab5=Ian.Campbell@citrix.com>)
	id 1ZB27r-0003Fr-4t
	for xen-devel@lists.xenproject.org; Fri, 03 Jul 2015 14:39:35 +0000
In-Reply-To: <1435934006.14347.75.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Rob Hoes <Rob.Hoes@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-07-03 at 16:33 +0200, Dario Faggioli wrote:
> On Fri, 2015-07-03 at 15:23 +0100, Ian Campbell wrote:
> > On Fri, 2015-07-03 at 12:24 +0200, Dario Faggioli wrote:
> > 
> > > @@ -5932,7 +5865,8 @@ int libxl_domain_sched_params_set(libxl_ctx *ctx, uint32_t domid,
> > >  
> > >      switch (sched) {
> > >      case LIBXL_SCHEDULER_SEDF:
> > > -        ret=sched_sedf_domain_set(gc, domid, scinfo);
> > > +        LOG(ERROR, "SEDF scheduler no longer available");
> > > +        ret=ERROR_INVAL;
> > 
> > Should we have a specific error code for removed functionality?
> > 
> Good point: shall I introduce it? If yes, how should it be called?
> 
> ERROR_REMOVED
> ERROR_DEPRECATED
> ERROR_GONE
> 
> I think I'd go for _REMOVED, as deprecated suggests (to me at least)
> that it's still there but nshould not be used.

REMOVED > DEPRECATED > GONE IMHO too.

> Any other ideas?

Not here, maybe someone on the cc has an opinion. In particular Ian has
been looking at error codes with Rob Hoes recent patches, maybe one of
them has some thoughts.

Ian.