From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: [PATCH v6 3/6] xen: arm: drop redundant extra call to vgic_reserve_virq Date: Fri, 3 Jul 2015 16:56:09 +0100 Message-ID: <1435938972-18288-3-git-send-email-ian.campbell@citrix.com> References: <1435938959.9447.171.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435938959.9447.171.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: julien.grall@citrix.com, Ian Campbell , stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org This is only needed if we are giving the IRQ to dom0 (as opposed to setting it up for passthrough due to xen,passthrough property). There is already a call to vgic_reserve_virq inside the if ( need_mapping ), so drop this one. Signed-off-by: Ian Campbell Reviewed-by: Julien Grall --- v4: New patch --- xen/arch/arm/domain_build.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 04460b0..980a2a3 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1024,12 +1024,6 @@ static int handle_device(struct domain *d, struct dt_device_node *dev) irq = res; DPRINT("irq %u = %u\n", i, irq); - /* - * Checking the return of vgic_reserve_virq is not - * necessary. It should not fail except when we try to map - * the IRQ twice. This can legitimately happen if the IRQ is shared - */ - vgic_reserve_virq(d, irq); res = irq_permit_access(d, irq); if ( res ) -- 1.7.10.4