From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 1/7] libxl: get rid of the SEDF scheduler Date: Mon, 6 Jul 2015 18:17:50 +0200 Message-ID: <1436199470.10763.11.camel@citrix.com> References: <20150706152620.12310.7021.stgit@Solace.station> <20150706153043.12310.43382.stgit@Solace.station> <559AA178.5030600@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1377501203200495994==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZC95h-0008Sa-Ns for xen-devel@lists.xenproject.org; Mon, 06 Jul 2015 16:17:57 +0000 In-Reply-To: <559AA178.5030600@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Wei Liu , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============1377501203200495994== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-OF+XSjYlea4rNRycQu6T" --=-OF+XSjYlea4rNRycQu6T Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-07-06 at 16:40 +0100, George Dunlap wrote: > On 07/06/2015 04:30 PM, Dario Faggioli wrote: > > only the interface is left in place, for backward > > compile-time compatibility, but every attempt to > > use it would throw an error. > >=20 > > Signed-off-by: Dario Faggioli > > Reviewed-by: George Dunlap >=20 > This probably should have been dropped... >=20 > > Chenges from v2: > > - introduce and use ERROR_FEATURE_REMOVED, as requested > > during review; > > - mark the SEDF only parameter as deprecated in libxl_types.idl, > > as requested during review. >=20 > ...given these. One question: >=20 Really? I'm basically only adding commentary, not changing (or adding, or removing) a single line of code... I mean, the deprecation was de-facto there already, since v1, it just was not stated explicitly anywhere in that particular file. That's why I didn't think a something like adding this comment would call for removal of the tag. Anyway, sorry for this. :-) > > @@ -356,9 +357,13 @@ libxl_domain_sched_params =3D Struct("domain_sched= _params",[ > > ("weight", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_W= EIGHT_DEFAULT'}), > > ("cap", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_C= AP_DEFAULT'}), > > ("period", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_P= ERIOD_DEFAULT'}), > > - ("slice", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_S= LICE_DEFAULT'}), > > - ("latency", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_L= ATENCY_DEFAULT'}), > > - ("extratime", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_E= XTRATIME_DEFAULT'}), > > + # The following three parameters ('slice', 'latency' and 'extratim= e') are deprecated, > > + # and will have no effect if used, since the SEDF scheduler has be= en removed. > > + # Note that 'period' was an SDF parameter too, but it is still eff= ective as it is > > + # now used (together with 'budget') by the RTDS scheduler. > > + ("slice", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_S= LICE_DEFAULT'}), # deprecated > > + ("latency", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_L= ATENCY_DEFAULT'}), # deprecated > > + ("extratime", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_E= XTRATIME_DEFAULT'}), # deprecated > > ("budget", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_B= UDGET_DEFAULT'}), >=20 > Since we're aiming for API compatibility rather than ABI compatibility, > is it allowable to move 'budget' up above the comment, so that it's more > obvious that it hasn't been deprecated? >=20 It's tool's people call, I guess. My opinion is that, yes, it should be possible without any issue, and yes, I also would like the end result better. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-OF+XSjYlea4rNRycQu6T Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlWaqi4ACgkQk4XaBE3IOsSj+QCgiYO5nT9yIi3rYm8hyv0fTObz G3cAn3Bx3MlYapNpXw7qd4YIGjICtWdf =CdLE -----END PGP SIGNATURE----- --=-OF+XSjYlea4rNRycQu6T-- --===============1377501203200495994== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1377501203200495994==--