From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 1/7] libxl: get rid of the SEDF scheduler Date: Mon, 6 Jul 2015 19:44:14 +0200 Message-ID: <1436204654.10763.49.camel@citrix.com> References: <20150706152620.12310.7021.stgit@Solace.station> <20150706153043.12310.43382.stgit@Solace.station> <559AA178.5030600@eu.citrix.com> <1436199470.10763.11.camel@citrix.com> <559AAB37.8010003@eu.citrix.com> <21914.44075.56339.297524@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0452649052524066426==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZCARn-0006QW-3A for xen-devel@lists.xenproject.org; Mon, 06 Jul 2015 17:44:51 +0000 In-Reply-To: <21914.44075.56339.297524@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: George Dunlap , xen-devel@lists.xenproject.org, Wei Liu , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org --===============0452649052524066426== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-bnmiq9bbVmQ/fejbAHd8" --=-bnmiq9bbVmQ/fejbAHd8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-07-06 at 17:26 +0100, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH v3 1/7] libxl: get rid of t= he SEDF scheduler"): > > On 07/06/2015 05:17 PM, Dario Faggioli wrote: > > I probably wouldn't even have bothered saying anything if I hadn't > > already been replying to the e-mail because of the line below. :-) >=20 > Also, while public-facing API comments are only comments (only > documentation), they are quite important. >=20 > A change like this: >=20 > > >>> - mark the SEDF only parameter as deprecated in libxl_types.idl, > > >>> as requested during review. >=20 > warrants dropping an acked/reviewed-by (unless it was requested or > suggested by the reviewer). >=20 Right, makes sense, and I see it now. Thanks. :-) So, while you're here, should I send v4 with the 'budget' field moved up? Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-bnmiq9bbVmQ/fejbAHd8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlWavm4ACgkQk4XaBE3IOsQiWwCgkmsSCGutXBvpAh59jjwgVFZD Ck4An008NSZG3wEM4naJDoln+HJTlDes =nHI8 -----END PGP SIGNATURE----- --=-bnmiq9bbVmQ/fejbAHd8-- --===============0452649052524066426== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0452649052524066426==--