xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, wei.liu2@citrix.com
Cc: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Subject: [PATCH 4/5] tools: Link in-tree libvchan and libblktapctl users against lib....so
Date: Tue, 7 Jul 2015 16:40:31 +0100	[thread overview]
Message-ID: <1436283632-6370-4-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1436283618.25646.253.camel@citrix.com>

As with other in-tree users avoid -L + -l.

This avoids any confusion with versions of these libraries already
installed on the system and the possibility of linking against them by
mistake.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 tools/Rules.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/Rules.mk b/tools/Rules.mk
index 3c29d07..2c422bd 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -51,7 +51,7 @@ LDLIBS_libxenstat  = $(SHLIB_libxenctrl) $(SHLIB_libxenstore) $(XEN_LIBXENSTAT)/
 SHLIB_libxenstat  = -Wl,-rpath-link=$(XEN_LIBXENSTAT)
 
 CFLAGS_libxenvchan = -I$(XEN_LIBVCHAN)
-LDLIBS_libxenvchan = $(SHLIB_libxenctrl) $(SHLIB_libxenstore) -L$(XEN_LIBVCHAN) -lxenvchan
+LDLIBS_libxenvchan = $(SHLIB_libxenctrl) $(SHLIB_libxenstore) $(XEN_LIBVCHAN)/libxenvchan$(libextension)
 SHLIB_libxenvchan  = -Wl,-rpath-link=$(XEN_LIBVCHAN)
 
 ifeq ($(debug),y)
@@ -65,7 +65,7 @@ LIBXL_BLKTAP ?= $(CONFIG_BLKTAP2)
 
 ifeq ($(LIBXL_BLKTAP),y)
 CFLAGS_libblktapctl = -I$(XEN_BLKTAP2)/control -I$(XEN_BLKTAP2)/include $(CFLAGS_xeninclude)
-LDLIBS_libblktapctl = -L$(XEN_BLKTAP2)/control -lblktapctl
+LDLIBS_libblktapctl = $(XEN_BLKTAP2)/control/libblktapctl$(libextension)
 SHLIB_libblktapctl  = -Wl,-rpath-link=$(XEN_BLKTAP2)/control
 else
 CFLAGS_libblktapctl =
-- 
2.1.4

  parent reply	other threads:[~2015-07-07 15:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07 15:40 [PATCH 0/5] tools: 3 misc fixes/cleanups Ian Campbell
2015-07-07 15:40 ` [PATCH 1/5] tools: libxc: fix "alocated" typo in comment Ian Campbell
2015-07-07 16:02   ` Ian Jackson
2015-07-07 15:40 ` [PATCH 2/5] libxc: Correct log message in xc_map_foreign_bulk Ian Campbell
2015-07-07 16:02   ` Ian Jackson
2015-07-07 15:40 ` [PATCH 3/5] tools: libxl: Log on more error paths on domain create failure Ian Campbell
2015-07-07 16:02   ` Ian Jackson
2015-07-07 15:40 ` Ian Campbell [this message]
2015-07-07 16:03   ` [PATCH 4/5] tools: Link in-tree libvchan and libblktapctl users against lib....so Ian Jackson
2015-07-07 15:40 ` [PATCH 5/5] tools: Do not add top-level tools dir to include path Ian Campbell
2015-07-07 16:03   ` Ian Jackson
2015-07-07 15:50 ` [PATCH 0/5] tools: 3 misc fixes/cleanups Wei Liu
2015-07-07 16:05   ` Ian Campbell
2015-07-08 12:44   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436283632-6370-4-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).