From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 for Xen 4.6 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler Date: Tue, 7 Jul 2015 17:46:02 +0200 Message-ID: <1436283962.22672.135.camel@citrix.com> References: <1435545899-22751-1-git-send-email-chong.li@wustl.edu> <1435545899-22751-2-git-send-email-chong.li@wustl.edu> <559BB101020000780008D371@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6158093373321419732==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chong Li Cc: Chong Li , Sisu Xi , George Dunlap , xen-devel , Meng Xu , Jan Beulich , Dagaen Golomb List-Id: xen-devel@lists.xenproject.org --===============6158093373321419732== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-U6Z4ZpbrZSqr2fl8Xiyi" --=-U6Z4ZpbrZSqr2fl8Xiyi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-07-07 at 10:33 -0500, Chong Li wrote: > On Tue, Jul 7, 2015 at 3:59 AM, Jan Beulich wrote: > > > > With this type gone I'm not even sure we need to wrap this in > > another union; not doing so would eliminate some of the other > > changes in this patch. >=20 > I see your point. Because of xen_domctl_schedparam_vcpu_t, we still > need to define struct xen_domctl_sched_sedf/credit/credit2/rtds > outside of struct xen_domctl_scheduler_op. Then the struct would be > like: >=20 > struct xen_domctl_scheduler_op { > uint32_t sched_id; /* XEN_SCHEDULER_* */ > uint32_t cmd; /* XEN_DOMCTL_SCHEDOP_* */ > union { > struct xen_domctl_sched_sedf sedf; > struct xen_domctl_sched_credit credit; > struct xen_domctl_sched_credit2 credit2; > struct xen_domctl_sched_rtds rtds; > struct { > XEN_GUEST_HANDLE_64(xen_domctl_schedparam_vcpu_t) vcpus; > uint16_t nr_vcpus; > } v; > } u; > }; > typedef struct xen_domctl_scheduler_op xen_domctl_scheduler_op_t; >=20 > This design is good for compatibility. Dario, what do you think? >=20 I understood Jan's suggestion in the same exact way as you, as you can see in my own email, and I like it. Sorry for being a bit out-of-sync, I've been having internet issues today (now things are working, but I'm not sure it'd be permanent! :-/). Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-U6Z4ZpbrZSqr2fl8Xiyi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlWb9EAACgkQk4XaBE3IOsRlggCgngfTYAyaFihnwibm9ZyUAtxj Wd0AoIWyl2dPjdCIvPkbzBB/6G4pqbQZ =BtZZ -----END PGP SIGNATURE----- --=-U6Z4ZpbrZSqr2fl8Xiyi-- --===============6158093373321419732== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6158093373321419732==--