From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] blkif.h: document physical-device node
Date: Tue, 7 Jul 2015 17:07:01 +0100
Message-ID: <1436285221.25646.266.camel@citrix.com>
References: <1436284132-2519-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=623ef3e9e=Ian.Campbell@citrix.com>)
	id 1ZCVP1-0004W3-GL
	for xen-devel@lists.xenproject.org; Tue, 07 Jul 2015 16:07:23 +0000
In-Reply-To: <1436284132-2519-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, David Vrabel <david.vrabel@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-07-07 at 16:48 +0100, Wei Liu wrote:
> This node is used by toolstack (libxl, hotplug script) and blkback.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Roger Pau Monne <roger.pau@citrix.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> 
> I notice this when I was looking at George's patch series to fix hotplug
> scripts. If anyone has better idea how we can document this feel free to
> provide alternative.

It looks perfectly fine to me, maybe you might want to insert a "block"
before the device, but in any case:

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> ---
>  xen/include/public/io/blkif.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
> index 6baf7fb..8f0f9a6 100644
> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -92,6 +92,12 @@
>   *      backend driver to open the backing device.  (e.g. the path to the
>   *      file or block device representing the backing store.)
>   *
> + * physical-device
> + *      Values:         "MAJOR:MINOR"
> + *
> + *      MAJOR and MINOR are the major number and minor number of the
> + *      backing device respectively.
> + *
>   * type
>   *      Values:         "file", "phy", "tap"
>   *