From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH 1/6] xl: Do not ignore unparseable PCI BDFs Date: Tue, 7 Jul 2015 17:13:20 +0100 Message-ID: <1436285605-18411-2-git-send-email-ian.jackson@eu.citrix.com> References: <1436285605-18411-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436285605-18411-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xensource.com Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org If xlu_pci_parse_bdf fails, abandon the domain creation, rather than blundering on. Signed-off-by: Ian Jackson Acked-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 08484e4..31d8260 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -1942,8 +1942,12 @@ skip_vfb: pcidev->power_mgmt = pci_power_mgmt; pcidev->permissive = pci_permissive; pcidev->seize = pci_seize; - if (!xlu_pci_parse_bdf(config, pcidev, buf)) - d_config->num_pcidevs++; + e = xlu_pci_parse_bdf(config, pcidev, buf); + if (e) { + fprintf(stderr, "unable to parse PCI BDF for passthrough\n"); + exit(-e); + } + d_config->num_pcidevs++; } if (d_config->num_pcidevs && c_info->type == LIBXL_DOMAIN_TYPE_PV) libxl_defbool_set(&b_info->u.pv.e820_host, true); -- 1.7.10.4