From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH 5/6] xl: Use xasprintf for cpupoolnumsplit names Date: Tue, 7 Jul 2015 17:13:24 +0100 Message-ID: <1436285605-18411-6-git-send-email-ian.jackson@eu.citrix.com> References: <1436285605-18411-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436285605-18411-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xensource.com Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org Otherwise we have to do complicated reasoning about the length that %d might produce. Signed-off-by: Ian Jackson Acked-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index c876d3e..4396095 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -7735,7 +7735,7 @@ int main_cpupoolnumasplit(int argc, char **argv) int n_pools; int node; int n_cpus; - char name[16]; + char *name = NULL; libxl_uuid uuid; libxl_bitmap cpumap; libxl_cpupoolinfo *poolinfo; @@ -7783,7 +7783,7 @@ int main_cpupoolnumasplit(int argc, char **argv) goto out; } - snprintf(name, 15, "Pool-node%d", node); + xasprintf(&name, "Pool-node%d", node); if (libxl_cpupool_rename(ctx, name, 0)) { fprintf(stderr, "error on renaming Pool 0\n"); goto out; @@ -7828,7 +7828,8 @@ int main_cpupoolnumasplit(int argc, char **argv) goto out; } - snprintf(name, 15, "Pool-node%d", node); + free(name); + xasprintf(&name, "Pool-node%d", node); libxl_uuid_generate(&uuid); poolid = 0; if (libxl_cpupool_create(ctx, name, sched, cpumap, &uuid, &poolid)) { @@ -7853,6 +7854,7 @@ int main_cpupoolnumasplit(int argc, char **argv) out: libxl_cputopology_list_free(topology, n_cpus); libxl_bitmap_dispose(&cpumap); + free(name); return rc; } -- 1.7.10.4