From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 for Xen 4.6 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler Date: Wed, 8 Jul 2015 16:45:34 +0200 Message-ID: <1436366734.22672.209.camel@citrix.com> References: <1435545899-22751-1-git-send-email-chong.li@wustl.edu> <1435545899-22751-4-git-send-email-chong.li@wustl.edu> <1436286236.22672.149.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1133143747099701245==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chong Li Cc: Chong Li , Wei Liu , Sisu Xi , George Dunlap , Ian Jackson , xen-devel , Ian Campbell , Meng Xu , Dagaen Golomb List-Id: xen-devel@lists.xenproject.org --===============1133143747099701245== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-jwIDJ20rYlll1tKrVbFm" --=-jwIDJ20rYlll1tKrVbFm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2015-07-08 at 09:35 -0500, Chong Li wrote: > On Tue, Jul 7, 2015 at 11:23 AM, Dario Faggioli > >> > >> +/* Per-VCPU parameters*/ > >> +#define LIBXL_DOMAIN_SCHED_PARAM_VCPU_INDEX_DEFAULT -1 > >> + > >> int libxl_domain_sched_params_get(libxl_ctx *ctx, uint32_t domid, > >> libxl_domain_sched_params *params); > >> int libxl_domain_sched_params_set(libxl_ctx *ctx, uint32_t domid, > >> const libxl_domain_sched_params *pa= rams); > >> +int libxl_vcpu_sched_params_get(libxl_ctx *ctx, uint32_t domid, > >> + libxl_vcpu_sched_params *params); > >> +int libxl_vcpu_sched_params_set(libxl_ctx *ctx, uint32_t domid, > >> + const libxl_vcpu_sched_params *para= ms); > >> > > Didn't we say that we wanted the fact that now, at least for RTDS, > > libxl_domain_sched_params_*() deals with default parameters to be > > documented in a comment somewhere? Have I missed it? >=20 > I'll implement it in the next version. >=20 > Do both get/set deal with default parameters? I can easily implement > it in hypervisor, because default parameters > (RTDS_DEFAULT_PERIOD/BUDGET) are just defined there. But for libxl, > how do I deal with it without knowing the default values? > What I meant was that I am ok with this being implemented in the hypervisor, but I think we want a comment explaining the difference between the two sets of operations (the _domain_ one and the _vcpu_ one) here in the library too. And in such a comment, it would be good to mention what the _domain_ call does for a scheduler that supports per-vcpu parameters (and the vice-versa, which, yes, is rather trivial, but still). The aim would be to give an libxl user an idea of what function he/she wants, depending on what scheduler and on which parameter, to achieve its purposes, and what (kind of error/behavior) should be expected if the wrong one is used. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-jwIDJ20rYlll1tKrVbFm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlWdN5UACgkQk4XaBE3IOsQLzgCeKomfHyAnSMgz3VA+Q7jbf+nO 3PkAn1nOkHagQBA1eXznGHTEJcQbN8AG =nD+C -----END PGP SIGNATURE----- --=-jwIDJ20rYlll1tKrVbFm-- --===============1133143747099701245== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1133143747099701245==--