From: Ian Campbell <ian.campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: wei.liu2@citrix.com, xen-devel@lists.xensource.com,
Ian.Jackson@eu.citrix.com
Subject: Re: [PATCH v6] run QEMU as non-root
Date: Thu, 9 Jul 2015 11:31:39 +0100 [thread overview]
Message-ID: <1436437899.23508.98.camel@citrix.com> (raw)
In-Reply-To: <1435755052-19447-1-git-send-email-stefano.stabellini@eu.citrix.com>
On Wed, 2015-07-01 at 13:50 +0100, Stefano Stabellini wrote:
> @@ -878,6 +908,33 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
> default:
> break;
> }
> +
> + if (b_info->device_model_user) {
> + user = b_info->device_model_user;
> + if (libxl__dm_runas_helper(gc, user) <= 0)
> + user = NULL;
I think this case should be an error, rather than continuing and running
qemu as root.
Ian.
next prev parent reply other threads:[~2015-07-09 10:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 12:50 [PATCH v6] run QEMU as non-root Stefano Stabellini
2015-07-01 15:29 ` Dario Faggioli
2015-07-01 15:34 ` Stefano Stabellini
2015-07-01 21:03 ` Jim Fehlig
2015-07-09 10:34 ` Ian Campbell
2015-07-09 23:14 ` Jim Fehlig
2015-07-10 8:40 ` Ian Campbell
2015-07-09 10:31 ` Ian Campbell [this message]
2015-07-23 17:04 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436437899.23508.98.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).