From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 17/27] tools/libxl: Support converting a legacy stream to a v2 stream Date: Fri, 10 Jul 2015 11:28:00 +0100 Message-ID: <1436524080.23508.226.camel@citrix.com> References: <1436466413-25867-1-git-send-email-andrew.cooper3@citrix.com> <1436466413-25867-18-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436466413-25867-18-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Wei Liu , Ian Jackson , Xen-devel List-Id: xen-devel@lists.xenproject.org On Thu, 2015-07-09 at 19:26 +0100, Andrew Cooper wrote: > When a legacy stream is found, it needs to be converted to a v2 stream for the > reading logic. This is done by exec()ing the python conversion utility. > > One complication is that the caller of this interface needs to assume > ownership of the output fd, to prevent it being closed while still in use in a > datacopier. > > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu I think various internals should use the libxl__convert_legacy_stream_inuse helper. With that: Acked-by: Ian Campbell Perhaps libxl__conversion_helper_state could become empty on !x86? My Ack stands either way.