From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3] x86: correct socket_cpumask allocation Date: Fri, 10 Jul 2015 16:57:15 +0200 Message-ID: <1436540235.22672.425.camel@citrix.com> References: <1436451837-26171-1-git-send-email-chao.p.peng@linux.intel.com> <1436538580.22672.420.camel@citrix.com> <559FDB1A.8030402@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4058980144716005738==" Return-path: In-Reply-To: <559FDB1A.8030402@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Chao Peng , boris.ostrovsky@oracle.com, keir@xen.org, JBeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============4058980144716005738== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-NINewRn6S5XoDMAgs6Y/" --=-NINewRn6S5XoDMAgs6Y/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-07-10 at 15:47 +0100, Andrew Cooper wrote: > On 10/07/15 15:29, Dario Faggioli wrote: > > (XEN) Xen call trace: > > (XEN) [] cpu_smpboot_free+0x2b/0x255 > > (XEN) [] cpu_smpboot_callback+0x317/0x327 > > (XEN) [] notifier_call_chain+0x67/0x87 > > (XEN) [] cpu_down+0xd9/0x12c > > (XEN) [] disable_nonboot_cpus+0x93/0x138 > > (XEN) [] enter_state_helper+0xbd/0x365 > > (XEN) [] continue_hypercall_tasklet_handler+0x4a/0= xb1 > > (XEN) [] do_tasklet_work+0x78/0xab > > (XEN) [] do_tasklet+0x5e/0x8a > > (XEN) [] idle_loop+0x56/0x6b > > (XEN)=20 > > (XEN) Pagetable walk from ffff830b2072a5b8: > > (XEN) L4[0x106] =3D 00000000dba9a063 ffffffffffffffff > > (XEN) L3[0x02c] =3D 0000000000000000 ffffffffffffffff > > (XEN)=20 > > (XEN) **************************************** > > (XEN) Panic on CPU 0: > > (XEN) FATAL PAGE FAULT > > (XEN) [error_code=3D0000] > > (XEN) Faulting linear address: ffff830b2072a5b8 > > (XEN) **************************************** >=20 > Confirmed - this is also an issue for me. It is only shutdown; reboot > appears to be fine. >=20 I added this printk: printk(" cpu=3D%u cpu_to_socket=3D%u\n", cpu, socket); Right before this chunk of code, in cpu_smpboot_free(): if ( cpumask_empty(socket_cpumask[socket]) ) { xfree(socket_cpumask[socket]); socket_cpumask[socket] =3D NULL; } And it says this: ... (XEN) Preparing system for ACPI S5 state. (XEN) Disabling non-boot CPUs ... (XEN) Broke affinity for irq 9 (XEN) cpu=3D1 cpu_to_socket=3D4294967295 (XEN) ----[ Xen-4.6-unstable x86_64 debug=3Dy Tainted: C ]---- (XEN) CPU: 0 (XEN) RIP: e008:[] cpu_smpboot_free+0x43/0x28b ... I.e., it looks like phys_proc_id has already been reset to XEN_INVALID_SOCKET_ID, as we're kind-of racing with remove_siblinginfo(). I'll keep looking, but not for too long... Chao, ping? Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-NINewRn6S5XoDMAgs6Y/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlWf3VEACgkQk4XaBE3IOsQX/wCaAu7g1W6YVtRjGJJ74BQbKNkS P7cAn3PP09zX9AXprWE7qg/ySAWpw868 =0AZi -----END PGP SIGNATURE----- --=-NINewRn6S5XoDMAgs6Y/-- --===============4058980144716005738== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4058980144716005738==--