From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH V2 1/1] libxl: set stub domain size based on
	VRAM size
Date: Mon, 13 Jul 2015 11:37:37 +0100
Message-ID: <1436783857.7019.84.camel@citrix.com>
References: <1436566472-13962-1-git-send-email-eshelton@pobox.com>
	<1436566472-13962-2-git-send-email-eshelton@pobox.com>
	<21923.36837.120581.140825@mariner.uk.xensource.com>
	<21923.37235.852479.985765@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=629d1b08a=Ian.Campbell@citrix.com>)
	id 1ZEb7H-0001UK-FH
	for xen-devel@lists.xenproject.org; Mon, 13 Jul 2015 10:37:43 +0000
In-Reply-To: <21923.37235.852479.985765@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com, samuel.thibault@ens-lyon.org, Eric Shelton <eshelton@pobox.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-07-13 at 11:22 +0100, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH V2 1/1] libxl: set stub domain size based on VRAM size"):
> > Eric Shelton writes ("[PATCH V2 1/1] libxl: set stub domain size based on VRAM size"):
> > > Allocate additional memory to the stub domain for qemu-traditional if
> > > more than 4 MB is assigned to the video adapter to avoid out of memory
> > > condition for QEMU.
> > 
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > 
> > This is IMO a bugfix so I am queueing it for 4.6.
> 
> My build test failed.  It turns out that max() is no good because the
> types of `4096' and `guest_config->b_info.video_memkb' are not the
> same.
> 
> In a moment I am going to send a v3 which uses max_t and uint64_t
> (which is the type of the memkb fields and also obviously correct).

Eric already sent a v3 in
<1436650242-1067-2-git-send-email-eshelton@pobox.com> which avoids the
use of max in a different way.

I think his approach looked fine.

Ian.