Re: [PATCH OSSTEST v2 10/13] TestSupport: don't put kernel='hvmloader' in HVM config

[Ian Campbell <ian.campbell@citrix.com>]

On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote:
> Setting kernel to hvmloader is ignored in xl but not in libvirt. Libvirt
> config converter will translate that then pass it to QEMU. QEMU
> complains there is no kernel called hvmloader and exits.
> 
> Just remove this option. Xl is not affected and libvirt will be able to
> create HVM guest.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Not sure if this affects Xend. We seem to only have one test case for
> xend in 4.3.

I fear it might indeed break things for 4.3 and older with xend.

> ---
>  Osstest/TestSupport.pm | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> index 66dc218..5336079 100644
> --- a/Osstest/TestSupport.pm
> +++ b/Osstest/TestSupport.pm
> @@ -1625,7 +1625,6 @@ sub more_prepareguest_hvm ($$$$;@) {
>      my $disks = join ",\t\t\n", map { "'$_'" } @disks;
>  
>      my $cfg = <<END;
> -kernel      = 'hvmloader'
>  builder     = 'hvm'
>  #
>  disk        = [