From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v2 11/13] make-flight: debian hvm
 tests with libvirt
Date: Mon, 13 Jul 2015 12:33:24 +0100
Message-ID: <1436787204.7019.112.camel@citrix.com>
References: <1436718036-7985-1-git-send-email-wei.liu2@citrix.com>
	<1436718036-7985-12-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=629d1b08a=Ian.Campbell@citrix.com>)
	id 1ZEbzE-0004K9-TR
	for xen-devel@lists.xenproject.org; Mon, 13 Jul 2015 11:33:29 +0000
In-Reply-To: <1436718036-7985-12-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote:
> @@ -215,16 +217,17 @@ do_hvm_debian_test_one () {
>    bios=$2
>    xsm=$3
>    stubdom=$4
> +  toolstack=$5

Nit: For consistency with other similar function (job_create and filter
in particular) I think toolstack should be inserted as $2, after
$testname and before $bios.

Otherwise things look good to me. A diff of the runvars is always nice
though.

Ian.