From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 1/9] libxl: fix libxl__abs_path
Date: Tue, 14 Jul 2015 08:23:15 +0100
Message-ID: <1436858595.7019.118.camel@citrix.com>
References: <1436551257-28887-1-git-send-email-wei.liu2@citrix.com>
	<1436551257-28887-2-git-send-email-wei.liu2@citrix.com>
	<1436781452.7019.61.camel@citrix.com>
	<21923.61840.920833.811619@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=630a0ae6d=Ian.Campbell@citrix.com>)
	id 1ZEuZ8-0002SI-TZ
	for xen-devel@lists.xenproject.org; Tue, 14 Jul 2015 07:23:47 +0000
In-Reply-To: <21923.61840.920833.811619@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wei.liu2@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-07-13 at 18:12 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 1/9] libxl: fix libxl__abs_path"):
> > I rather dislike subjects of the form "fix $function", since it gives
> > very little clue to someone reading the shortlog what is going on.
> 
> Yes.
> 
> > In this case I think "libxl: make libxl__abs_path correctly handle a
> > NULL argument" would be an accurate description.
> 
> But: it is quite surprising that libxl__abs_path can be legally passed
> a NULL for any of its parameters.

True.
> 
> There are no call sites in libxl which can pass a NULL.
> 
> I think that if we are to retain this feature, it ought to be
> documented, at least.
> 
> Maybe
> 
>   _hidden char *libxl__abs_path(libxl__gc *gc,
>                                 const char *s /* NULL OK */,
>                                 const char *path);

Or add an assert if we don't wish to support this?