From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH V5 0/3] Vm_event memory introspection helpers
Date: Tue, 14 Jul 2015 14:08:53 +0100
Message-ID: <1436879333.25044.55.camel@citrix.com>
References: <1436807687-9826-1-git-send-email-rcojocaru@bitdefender.com>
	<55A505B10200007800090956@mail.emea.novell.com>
	<55A4F64E.3000707@bitdefender.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55A4F64E.3000707@bitdefender.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Razvan Cojocaru <rcojocaru@bitdefender.com>
Cc: jun.nakajima@intel.com, kevin.tian@intel.com, wei.liu2@citrix.com, Jan Beulich <JBeulich@suse.com>, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, eddie.dong@intel.com, Aravind.Gopalakrishnan@amd.com, suravee.suthikulpanit@amd.com, tlengyel@novetta.com, keir@xen.org, boris.ostrovsky@oracle.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-07-14 at 14:45 +0300, Razvan Cojocaru wrote:
> On 07/14/2015 01:50 PM, Jan Beulich wrote:
> >>>> On 13.07.15 at 19:14, <rcojocaru@bitdefender.com> wrote:
> >> I've also moved x86 logic in patch 3/3 to x86 source files, this
> >> seems to have gone unnoticed but would likely have not compiled
> >> on ARM.
> > 
> > Which leaves open whether this time you actually checked that
> > ARM continues to build.
> 
> I did check, and again just now. My patches don't break the ARM build,
> but I just found that on my ARM system, current Xen staging doesn't
> build: http://pastebin.com/RnywiCX7

This is a glibc error with your distro, like this
https://bugs.launchpad.net/linaro-aarch64/+bug/1169164

> I've temporarily fixed that by wrapping the offending #defines in
> "#ifndef constant" statements, so that I could continue to check that
> the build works, but that's likely not the proper fix.

Indeed, it the hack which works if you are unable to upgrade your libc
for some reason. FWIW I just applied the patches from that bug to the
installed copies of the relevant headers, which is certainly skanky...

Ian.