From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, Ian Campbell <Ian.Campbell@citrix.com>,
wency@cn.fujitsu.com, andrew.cooper3@citrix.com,
yunhong.jiang@intel.com, eddie.dong@intel.com,
guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [PATCH v4 --for 4.6 COLOPre 04/25] tools/libxl: rename remus checkpoint callbacks
Date: Wed, 15 Jul 2015 15:45:30 +0800 [thread overview]
Message-ID: <1436946351-21118-5-git-send-email-yanghy@cn.fujitsu.com> (raw)
In-Reply-To: <1436946351-21118-1-git-send-email-yanghy@cn.fujitsu.com>
There are 2 remus checkpoint callbacks(save/restore), currently, they
both called libxl__remus_domain_checkpoint_callback in diffrent
file, so it is ok. But in the following patch, we will move all of the
remus callback code into a seperate file, the name should be diffrent.
So rename them to:
libxl__remus_domain_{save/restore}_checkpoint_callback
Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
tools/libxl/libxl_create.c | 4 ++--
tools/libxl/libxl_dom.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index 5b4d333..a32e3df 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -677,7 +677,7 @@ static int store_libxl_entry(libxl__gc *gc, uint32_t domid,
static void remus_checkpoint_stream_done(
libxl__egc *egc, libxl__stream_read_state *srs, int rc);
-static void libxl__remus_domain_checkpoint_callback(void *data)
+static void libxl__remus_domain_restore_checkpoint_callback(void *data)
{
libxl__save_helper_state *shs = data;
libxl__domain_create_state *dcs = shs->caller_state;
@@ -989,7 +989,7 @@ static void domcreate_bootloader_done(libxl__egc *egc,
}
/* Restore */
- callbacks->checkpoint = libxl__remus_domain_checkpoint_callback;
+ callbacks->checkpoint = libxl__remus_domain_restore_checkpoint_callback;
rc = libxl__build_pre(gc, domid, d_config, state);
if (rc)
diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index 0788309..9c61fa7 100644
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -1586,7 +1586,7 @@ static void remus_next_checkpoint(libxl__egc *egc, libxl__ev_time *ev,
const struct timeval *requested_abs,
int rc);
-static void libxl__remus_domain_checkpoint_callback(void *data)
+static void libxl__remus_domain_save_checkpoint_callback(void *data)
{
libxl__save_helper_state *shs = data;
libxl__domain_suspend_state *dss = shs->caller_state;
@@ -1749,7 +1749,7 @@ void libxl__domain_save(libxl__egc *egc, libxl__domain_suspend_state *dss)
if (r_info != NULL) {
callbacks->suspend = libxl__remus_domain_suspend_callback;
callbacks->postcopy = libxl__remus_domain_resume_callback;
- callbacks->checkpoint = libxl__remus_domain_checkpoint_callback;
+ callbacks->checkpoint = libxl__remus_domain_save_checkpoint_callback;
dss->sws.checkpoint_callback = remus_checkpoint_stream_written;
} else
callbacks->suspend = libxl__domain_suspend_callback;
--
1.9.1
next prev parent reply other threads:[~2015-07-15 7:45 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 7:45 [PATCH v4 --for 4.6 COLOPre 00/25] Prerequisite patches for COLO Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 01/25] tools/libxl: rename libxl__domain_suspend to libxl__domain_save Yang Hongyang
2015-07-15 11:16 ` Ian Campbell
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 02/25] tools/libxl: move domain suspend code into libxl_dom_suspend.c Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 03/25] tools/libxl: move domain resume " Yang Hongyang
2015-07-15 7:45 ` Yang Hongyang [this message]
2015-07-15 11:17 ` [PATCH v4 --for 4.6 COLOPre 04/25] tools/libxl: rename remus checkpoint callbacks Ian Campbell
2015-07-16 1:43 ` Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 05/25] libxl/remus: introduce libxl__remus_setup Yang Hongyang
2015-07-15 11:26 ` Ian Campbell
2015-07-16 5:32 ` Yang Hongyang
2015-07-16 10:40 ` Ian Campbell
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 06/25] libxl/remus: introduce libxl__remus_teardown Yang Hongyang
2015-07-15 11:59 ` Ian Campbell
2015-07-16 1:43 ` Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 07/25] libxl/remus: init checkpoint_callback in Remus checkpoint callback Yang Hongyang
2015-07-15 12:02 ` Ian Campbell
2015-07-15 12:35 ` Yang Hongyang
2015-07-16 10:32 ` Ian Campbell
2015-07-16 11:00 ` Yang Hongyang
2015-07-16 11:16 ` Ian Campbell
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 08/25] tools/libxl: move remus code into libxl_remus.c Yang Hongyang
2015-07-15 12:05 ` Ian Campbell
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 09/25] tools/libxl: move save/restore code into libxl_dom_save.c Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 10/25] libxl/save: Refactor libxl__domain_suspend_state Yang Hongyang
2015-07-15 12:10 ` Ian Campbell
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 11/25] tools/libxc: support to resume uncooperative HVM guests Yang Hongyang
2015-07-15 12:26 ` Ian Campbell
2015-07-16 5:57 ` Yang Hongyang
2015-07-16 15:40 ` Ian Jackson
2015-07-16 16:15 ` Yang Hongyang
2015-07-16 16:27 ` Ian Jackson
2015-12-15 2:05 ` Wen Congyang
2016-01-04 16:33 ` Ian Jackson
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 12/25] tools/libxl: introduce enum type libxl_checkpointed_stream Yang Hongyang
2015-07-15 12:34 ` Ian Campbell
2015-07-15 13:58 ` Yang Hongyang
2015-07-16 10:34 ` Ian Campbell
2015-07-16 10:47 ` Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 13/25] migration/save: pass checkpointed_stream from libxl to libxc Yang Hongyang
2015-07-15 12:38 ` Ian Campbell
2015-07-16 6:05 ` Yang Hongyang
2015-07-16 10:47 ` Ian Campbell
2015-07-16 16:13 ` Wei Liu
2015-07-16 16:21 ` Yang Hongyang
2015-07-16 16:39 ` Wei Liu
2015-07-16 16:10 ` Wei Liu
2015-07-16 16:24 ` Yang Hongyang
2015-07-16 16:37 ` Wei Liu
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 14/25] tools/libxl: introduce libxl__domain_restore_device_model to load qemu state Yang Hongyang
2015-07-15 12:45 ` Ian Campbell
2015-07-15 13:42 ` Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 15/25] tools/libxl: check QEMU state before resume dm Yang Hongyang
2015-07-15 12:48 ` Ian Campbell
2015-07-15 12:54 ` Ian Campbell
2015-07-15 13:00 ` Wei Liu
2015-07-15 13:48 ` Ian Campbell
2015-07-15 13:49 ` Ian Campbell
2015-07-16 14:43 ` Wei Liu
2015-07-16 15:43 ` Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 16/25] tools/libxl: Update libxl_domain_unpause() to support qemu-xen Yang Hongyang
2015-07-15 12:50 ` Ian Campbell
2015-07-16 3:49 ` Yang Hongyang
2015-07-16 10:39 ` Ian Campbell
2015-07-16 10:51 ` Yang Hongyang
2015-07-16 16:26 ` Wei Liu
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 17/25] tools/libxl: introduce libxl__domain_common_switch_qemu_logdirty() Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 18/25] tools/libxl: export logdirty_init Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 19/25] tools/libxl: Add back channel to allow migration target send data back Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 20/25] tools/libx{l, c}: add back channel to libxc Yang Hongyang
2015-07-15 13:13 ` Ian Campbell
2015-07-16 6:29 ` Yang Hongyang
2015-07-16 11:01 ` Ian Campbell
2015-07-15 13:21 ` Andrew Cooper
2015-07-16 6:07 ` Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 21/25] tools/libxl: rename remus device to checkpoint device Yang Hongyang
2015-07-15 13:15 ` Ian Campbell
2015-07-15 13:34 ` Yang Hongyang
2015-07-16 9:26 ` Andrew Cooper
2015-07-16 9:29 ` Yang Hongyang
2015-07-15 13:32 ` Ian Campbell
2015-07-15 13:38 ` Yang Hongyang
2015-07-16 9:23 ` Yang Hongyang
2015-07-16 9:31 ` Ian Campbell
2015-07-16 9:36 ` Yang Hongyang
2015-07-16 10:14 ` Ian Campbell
2015-07-16 10:22 ` Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 22/25] tools/libxl: adjust the indentation Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 23/25] tools/libxl: store remus_ops in checkpoint device state Yang Hongyang
2015-07-15 13:21 ` Ian Campbell
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 24/25] tools/libxl: move remus state into a seperate structure Yang Hongyang
2015-07-15 13:28 ` Ian Campbell
2015-07-15 13:50 ` Yang Hongyang
2015-07-16 10:37 ` Ian Campbell
2015-07-16 11:10 ` Ian Jackson
2015-07-16 11:19 ` Ian Campbell
2015-07-15 15:08 ` Ian Jackson
2015-07-15 15:18 ` Yang Hongyang
2015-07-15 7:45 ` [PATCH v4 --for 4.6 COLOPre 25/25] tools/libxl: seperate device init/cleanup from checkpoint device layer Yang Hongyang
2015-07-15 13:37 ` Ian Campbell
2015-07-16 1:37 ` [PATCH v4 --for 4.6 COLOPre 00/25] Prerequisite patches for COLO Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436946351-21118-5-git-send-email-yanghy@cn.fujitsu.com \
--to=yanghy@cn.fujitsu.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).