From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v4 --for 4.6 COLOPre 01/25] tools/libxl: rename libxl__domain_suspend to libxl__domain_save Date: Wed, 15 Jul 2015 12:16:04 +0100 Message-ID: <1436958964.32371.5.camel@citrix.com> References: <1436946351-21118-1-git-send-email-yanghy@cn.fujitsu.com> <1436946351-21118-2-git-send-email-yanghy@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436946351-21118-2-git-send-email-yanghy@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Hongyang Cc: wei.liu2@citrix.com, eddie.dong@intel.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca List-Id: xen-devel@lists.xenproject.org On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: > The suspend/save terminology used by libxc is more consistent. > "suspend" refers to quiescing the VM, so pausing qemu, making a > remote_shutdown(SHUTDOWN_suspend) hypercall etc. > "save" refers to the actions involved in actually shuffling the > state of the VM, so xc_domain_save() etc. > > libxl currently uses "suspend" to encapsulate both. The patch > Rename libxl__domain_suspend() to libxl__domain_save() since it > actually refers to shuffling the state of the VM. > > This results in some strangeness in that some functions called *save* > are now passed a struct called *suspend*, this is temporary and is all > fixed up later by the refactoring of the suspend_state. > > Signed-off-by: Yang Hongyang > Some comments, commit messages: > Signed-off-by: Andrew Cooper Acked-by: Ian Campbell