From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 03/16] xen/passthrough: extend hypercall to
 support rdm reservation policy
Date: Thu, 23 Jul 2015 12:54:58 +0100
Message-ID: <1437652498.19412.94.camel@citrix.com>
References: <1437579859-24485-1-git-send-email-ian.jackson@eu.citrix.com>
	<1437579859-24485-4-git-send-email-ian.jackson@eu.citrix.com>
	<21936.54212.592097.157376@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21936.54212.592097.157376@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xensource.com, Wei Liu <wei.liu2@citrix.com>, Tiejun Chen <tiejun.chen@intel.com>, Jan
	Beulich <JBeulich@suse.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Yang Zhang <yang.z.zhang@intel.com>, Kevin Tian <kevin.tian@intel.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-07-23 at 12:45 +0100, Ian Jackson wrote:
> 
> I had a quick look but it's not a simple matter of plumbing through 
> an additional flags parameter becuase the reassign_device method
> apparently doesn't take flags.

The vtd version (reassign_device_ownership) does:
                /*
                 * Any RMRR flag is always ignored when remove a device,
                 * but its always safe and strict to set 0.
                 */
                ret = rmrr_identity_mapping(source, 0, rmrr, 0);

Where that second 0 there was the flag when it was called from
(intel_iommu_assign_device).

Given that arm_smmu_assign_dev currently ignores the flag, and that ARM
doesn't currently have RDM/RMRR at all I think just passing 0 in
arm_smmu_reassign_dev would be tolerable.

Ian.