From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com,
Iurii Konovalenko <iurii.konovalenko@globallogic.com>,
Wei.Liu2@citrix.com, ian.jackson@eu.citrix.com
Subject: Re: [PATCH for 4.6] xen/tools: Widen the machine_irq in xc_domain_*bind_pt_irq_int
Date: Fri, 24 Jul 2015 12:06:01 +0100 [thread overview]
Message-ID: <1437735961.24746.66.camel@citrix.com> (raw)
In-Reply-To: <1437488112.8383.38.camel@citrix.com>
On Tue, 2015-07-21 at 15:15 +0100, Ian Campbell wrote:
> On Fri, 2015-07-17 at 15:06 +0100, Julien Grall wrote:
> > The DOMCTLs {,un}bind_pt_irq are using uint32_t for the machine_irq
> > while the helper is using uint8_t.
> >
> > Currently on ARM, we are supporting SPIs whose irq number can go up
> >
> > to
> > 1019 which doesn't fit in an uint8_t. The helpers
> > xc_domain_bind_pt_spi
> > and xc_domain_unbint_pt_spi are correctly taking an uint16_t so the
> > libxc was truncating without noticing the user which may end up to
> > route the wrong IRQ.
> >
> > Fix the problem by widening the machine_irq parameter in
> > xc_domain_*bind_pt_irq_int.
> >
> > Note that XEN_DOMCTL_irq_permission has the same problem but it's
> > not
> > used at the moment on ARM. So we can defer the changes after the
> > release
> > of Xen 4.7.
> >
> > Reported-by: Iurii Konovalenko <iurii.konovalenko@globallogic.com>
> > Signed-off-by: Julien Grall <julien.grall@citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> I think this is a bugfix and should be applied for 4.6.
Done.
prev parent reply other threads:[~2015-07-24 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 14:06 [PATCH for 4.6] xen/tools: Widen the machine_irq in xc_domain_*bind_pt_irq_int Julien Grall
2015-07-21 14:15 ` Ian Campbell
2015-07-24 11:06 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437735961.24746.66.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Wei.Liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=iurii.konovalenko@globallogic.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).