From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v2 5/5] ms-flights-summary: Produce an HTML report of all active flights Date: Fri, 31 Jul 2015 16:58:23 +0100 Message-ID: <1438358303.30740.73.camel@citrix.com> References: <1436882318.25044.75.camel@citrix.com> <1436882332-6978-5-git-send-email-ian.campbell@citrix.com> <21947.39259.589923.46525@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21947.39259.589923.46525@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-07-31 at 16:50 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST v2 5/5] ms-flights-summary: Produce > an HTML report of all active flights"): > > This could surely use better Perl and produce better output, however > > I'm sending it now because it would be useful for further development > > if some or all of the preceding patches could go into production and > > this serves as an example of why I think I want them. > > I think it's pretty good actually. I have some minor stylistic > comments. I haven't inspected the output, but as you say we can > improve it later. Thanks, I actually posted a v3 shortly after which rewrote a lot of this. I'll try and apply those of your comments which are relevant to the v3 though. > > diff --git a/ms-planner b/ms-planner > > index f38f05b..35d430b 100755 > > --- a/ms-planner > > +++ b/ms-planner > > @@ -289,6 +289,7 @@ END > > $info= "rogue task $arow->{subtask}"; > > } > > $plan->{Allocations}{$reskey}= { > > + # Can we find a Job here? > > Task => $arow->{owntaskid}, > > Info => $info, > > I don't understand this comment. This didn't really belong in this patch. It was in relation to this paragraph from patch #1's commit message: cmd_reset does not include a ->Job for jobs which are "(preparing)", corresponding to a job which is going to use a shared host which is currently being installed by another job. I was unable to figure out a way to include these. The upshot is that N-1 of the N jobs which are going to share a host sit in the "Anonymous Jobs" list until the first job has finished with the actual installation of the host, instead of being associated with the proper job. I wasn't able to figure out how to get the original Job to include in those records in the allocations. Ian.