xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST v2] Arrange to test migration from the previous Xen version
Date: Mon, 3 Aug 2015 17:01:22 +0100	[thread overview]
Message-ID: <1438617682.31129.29.camel@citrix.com> (raw)
In-Reply-To: <1437755305-17200-1-git-send-email-ian.campbell@citrix.com>

On Fri, 2015-07-24 at 17:28 +0100, Ian Campbell wrote:
> @@ -191,6 +208,27 @@ create_build_jobs () {
>                  revision_ovmf=$REVISION_OVMF
>      done
>  
> +    if [ x$want_prevxen = xy ] ; then
> +        if [ "x$REVISION_PREVXEN" = x ] ; then
> +            echo >&2 "prevxen ?"; exit 1
> +        fi

This breaks things with standalone mode, or any make-flight which didn't
come from cr-daily-branch.

In such cases we don't have REVISION_XEN or TREE_XEN either, we just get
the defaults.

I think we need to do something like select_prevxenbranch but to pick a
xen.git branch name rather than an osstest branch name.

Or we quietly skip this test if REVISION_PREVXEN is not set.

One to chew on I think.

Ian.

  parent reply	other threads:[~2015-08-03 16:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 16:28 [PATCH OSSTEST v2] Arrange to test migration from the previous Xen version Ian Campbell
2015-07-24 16:29 ` Ian Jackson
2015-08-03 16:01 ` Ian Campbell [this message]
2015-08-11 11:30   ` Ian Campbell
2015-08-11 16:16     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438617682.31129.29.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).