xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	george.dunlap@eu.citrix.com, xen-devel@lists.xenproject.org,
	wei.liu2@citrix.com
Subject: Re: Second regression due to libxl: Remove linux udev rules (2ba368d13893402b2f1fb3c283ddcc714659dd9b)
Date: Tue, 4 Aug 2015 09:32:53 +0100	[thread overview]
Message-ID: <1438677173.31129.41.camel@citrix.com> (raw)
In-Reply-To: <55C07468.4040909@citrix.com>

On Tue, 2015-08-04 at 10:14 +0200, Roger Pau Monné wrote:
> This was not a problem when using udev, because there's no timeout, but 
> libxl has a hard timeout (10s) regarding hotplug script execution. The 
> only way I see to solve this is to remove the checks done in the block 
> hotplug script, or to increase the timeout (but since the execution 
> time is not bounded this is doomed to fail if enough guests are using 
> the same image).

If we have evidence (as we appear to) that the timeout is not sufficient
for starting large numbers of guests in // then increasing the timeout
would seem reasonable.

Perhaps someone could set an insane timeout and measure the maximum time
they see in practice in this test case. Then we could decide what a
reasonable timeout should be? Maybe we could even find a linear pattern in
the number of guests and use that to extrapolate a reasonable timeout?

That would be a small self contained fix which could be made for 4.6 I
think.

For 4.7 we could consider other options. I don't think we want to remove
the timeout altogether, but perhaps the mechanisms used for doing and/or
checking the level sharing could be optimised somewhat (perhaps by reusing
the loopback device?).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2015-08-04  8:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 19:47 Second regression due to libxl: Remove linux udev rules (2ba368d13893402b2f1fb3c283ddcc714659dd9b) Konrad Rzeszutek Wilk
2015-07-29  9:03 ` Ian Campbell
2015-07-29 10:52   ` Roger Pau Monné
2015-07-29 15:45     ` Konrad Rzeszutek Wilk
2015-07-30  8:17       ` Ian Campbell
2015-07-30  8:43         ` Roger Pau Monné
2015-07-30  8:56           ` Ian Campbell
2015-07-30  8:53 ` Roger Pau Monné
2015-08-04  8:14   ` Roger Pau Monné
2015-08-04  8:32     ` Ian Campbell [this message]
2015-08-04  9:44       ` Roger Pau Monné
2015-08-07 14:54     ` Konrad Rzeszutek Wilk
2015-08-07 14:58       ` Roger Pau Monné
2015-08-12 14:09         ` Konrad Rzeszutek Wilk
2015-08-18  7:49           ` Roger Pau Monné
2015-09-22 14:15             ` Konrad Rzeszutek Wilk
2015-08-11  8:52       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438677173.31129.41.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).