From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v7 2/8] cxenstored: add support for systemd
 active sockets
Date: Thu, 6 Aug 2015 12:03:00 +0100
Message-ID: <1438858980.9747.130.camel@citrix.com>
References: <CAFLBxZaUMwpjcRJvSr1UF4bg4BRKBWRDfQVy5hCpCbZVepiy_A@mail.gmail.com>
	<1438769878.9747.47.camel@citrix.com>
	<CAFLBxZanbzdNUFOeeUkGw+6mNk-9dL+1uV06ddRVzgHNFvFZyw@mail.gmail.com>
	<20150805131758.GM26074@zion.uk.xensource.com>
	<CAFLBxZYx+9vC2BR7orXZZtXY3-urY8GEZRKVx-9YZ9qVVLY8CA@mail.gmail.com>
	<20150805172437.GA15719@zion.uk.xensource.com>
	<20150805181920.GB15719@zion.uk.xensource.com>
	<1438852396.9747.123.camel@citrix.com>
	<20150806101719.GJ15719@zion.uk.xensource.com>
	<1438858095.9747.129.camel@citrix.com>
	<20150806105619.GK15719@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=653267a9e=Ian.Campbell@citrix.com>)
	id 1ZNIx3-0003Bw-ED
	for xen-devel@lists.xenproject.org; Thu, 06 Aug 2015 11:03:09 +0000
In-Reply-To: <20150806105619.GK15719@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org>, "Luis R. Rodriguez" <mcgrof@suse.com>, "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-08-06 at 11:56 +0100, Wei Liu wrote:
> On Thu, Aug 06, 2015 at 11:48:15AM +0100, Ian Campbell wrote:
> > On Thu, 2015-08-06 at 11:17 +0100, Wei Liu wrote:
> > > 
> > > I don't think so. Though the doc is not clear on how we should use 
> > > those
> > > APIs, I got my idea from 
> > > 
> > > http://0pointer.de/public/cups-patch-core.txt
> > > 
> > > which doesn't call sd_booted.
> > 
> > OK, FM then: Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > As a future cleanup I think some of the ifdeferry could be removed by
> > having systemd = false ifndef SYSTEMD_ENABLED, what do you think?
> 
> Maybe. In the end there has to be some ifdeferry some where to gate the
> implementation. As a future cleanup I think I can provide a stub
> systemd_checkin() which always returns false and remove all ifdef in
> main().

Right, that's what I meant, i.e. just reduce the amount of ifdef.

> 
> Wei.