From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for-4.6] tools/libxc: linux: Don't use
 getpagesize() when unmapping the grants
Date: Tue, 11 Aug 2015 13:48:54 +0100
Message-ID: <1439297334.9747.238.camel@citrix.com>
References: <1438973635-16517-1-git-send-email-julien.grall@citrix.com>
	<20150807214509.GA10919@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6588c5e28=Ian.Campbell@citrix.com>)
	id 1ZP8zC-0001AL-UF
	for xen-devel@lists.xenproject.org; Tue, 11 Aug 2015 12:48:59 +0000
In-Reply-To: <20150807214509.GA10919@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-08-07 at 22:45 +0100, Wei Liu wrote:
> On Fri, Aug 07, 2015 at 07:53:55PM +0100, Julien Grall wrote:
> > The grants are based on the Xen granularity (i.e 4KB). While the 
> > function
> > to map grants for Linux (linux_gnttab_grant_map) is using the correct
> > size (XC_PAGE_SIZE), the unmap one (linux_gnttab_munmap) is using
> > getpagesize().
> > 
> > On domain using a page granularity different than Xen (this is the case
> > for AARCH64 guest using 64KB page), the unmap will be called with the
> > wrong size.
> > 
> > Signed-off-by: Julien Grall <julien.grall@citrix.com>
> > 
> > ---
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > 
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> I think this is a bug fix and should be applied for 4.6.

Agreed.

WRT to backports for 4.5 I'd appreciate being given a full list of required
fixes once everything is in place and working for 4.6/devbranch rather than
my tracking it piecemeal.

Ian.