From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v2] Arrange to test migration from
 the previous Xen version
Date: Tue, 11 Aug 2015 17:16:20 +0100
Message-ID: <1439309780.9747.297.camel@citrix.com>
References: <1437755305-17200-1-git-send-email-ian.campbell@citrix.com>
	<1438617682.31129.29.camel@citrix.com>
	<1439292607.9747.222.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1439292607.9747.222.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-08-11 at 12:30 +0100, Ian Campbell wrote:
> On Mon, 2015-08-03 at 17:01 +0100, Ian Campbell wrote:
> > On Fri, 2015-07-24 at 17:28 +0100, Ian Campbell wrote:
> > > @@ -191,6 +208,27 @@ create_build_jobs () {
> > >                  revision_ovmf=$REVISION_OVMF
> > >      done
> > >  
> > > +    if [ x$want_prevxen = xy ] ; then
> > > +        if [ "x$REVISION_PREVXEN" = x ] ; then
> > > +            echo >&2 "prevxen ?"; exit 1
> > > +        fi
> > 
> > This breaks things with standalone mode, or any make-flight which 
> > didn't
> > come from cr-daily-branch.
> > 
> > In such cases we don't have REVISION_XEN or TREE_XEN either, we just 
> > get
> > the defaults.
> > 
> > I think we need to do something like select_prevxenbranch but to pick a
> > xen.git branch name rather than an osstest branch name.
> > 
> > Or we quietly skip this test if REVISION_PREVXEN is not set.
> > 
> > One to chew on I think.
> 
> At the moment I'm somewhat inclined towards omitting the build-$ARCH-prev
> job in this case but still creating the associated test jobs.

We discussed this IRL and concluded that build-$ARCH already ignores the
$xenbranch when REVISION_XEN is not specified i.e it always builds whatever
clone gives you, AKA master for xen.git and that having build-$ARCH-prev do
the same was at least no worse than that under those circumstances.

As a future yakk shaving exercise something should be taught to translate
osstest's $xenbranch in to a xen.git branch name (ap-push/ap-fetch-version
has this sort of code already) at which time this can all be fixed up.

I need to rebase over Wei's recent libvirt changes and will drop the 'if [
"x$REVISION_PREVXEN" = x ]' block.

Ian.