From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>,
Andrew Armenia <andrew@asquaredlabs.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-users@lists.xenproject.org
Subject: Re: [Xen-users] "xl restore" leaks a file descriptor?
Date: Wed, 12 Aug 2015 10:30:35 +0100 [thread overview]
Message-ID: <1439371835.9747.324.camel@citrix.com> (raw)
In-Reply-To: <1439368873.9747.302.camel@citrix.com>
On Wed, 2015-08-12 at 09:41 +0100, Ian Campbell wrote:
> On Tue, 2015-08-11 at 18:07 +0100, Wei Liu wrote:
> >
> > I don't see how CLOEXEC would be of any use if xl doesn't actually exec
> > anything.
>
> Duh, for some reason I thought daemonize would activate the CLOEXEC, but
> it's just fork without exec. Silly me.
FWIW I did manage to confirm that libxl isn't messing up the CLOEXEC state
of the FD, it correctly only clears it between the fork and exec when
spawning the save restore helper. Any messing which libxc does is safely
contained in that subprocess.
Ian.
next prev parent reply other threads:[~2015-08-12 9:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+jCKRWVz1UsybJq6w18-x4vDB5D2j=qi2uqdbqWFaVWv9Gu-A@mail.gmail.com>
[not found] ` <1438592915.30740.101.camel@citrix.com>
[not found] ` <CA+jCKRUSxG3nFC=BJCqKy=kABrN27Nde4A67bxBEm5TYD71yPA@mail.gmail.com>
[not found] ` <1439283311.9747.193.camel@citrix.com>
[not found] ` <CA+jCKRVqL4DOYZK-etugCnVRhOocVKYdhGQWG4XYCqWZUWcmfA@mail.gmail.com>
2015-08-11 15:48 ` [Xen-users] "xl restore" leaks a file descriptor? Ian Campbell
2015-08-11 15:56 ` Andrew Cooper
2015-08-11 17:07 ` Wei Liu
2015-08-11 17:21 ` Andrew Cooper
2015-08-11 20:06 ` Wei Liu
2015-08-12 8:41 ` Ian Campbell
2015-08-12 9:30 ` Ian Campbell [this message]
2015-08-12 9:49 ` Wei Liu
2015-08-12 10:04 ` Ian Campbell
2015-08-12 17:12 ` Wei Liu
2015-08-13 8:39 ` Ian Campbell
2015-08-13 8:50 ` Wei Liu
2015-08-13 9:17 ` Ian Campbell
2015-08-13 9:38 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439371835.9747.324.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew@asquaredlabs.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xen-users@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).