From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [BUG][4.5.1]xl cpupool-create segfault (with config file parameter) Date: Thu, 13 Aug 2015 11:01:04 +0200 Message-ID: <1439456464.24583.57.camel@citrix.com> References: <55CB27F2.60903@desaster-games.com> <1439378931.8356.20.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0311743768839065777==" Return-path: In-Reply-To: <1439378931.8356.20.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Benjamin Beier , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --===============0311743768839065777== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-eca0yVtInnX8fY32J5kB" --=-eca0yVtInnX8fY32J5kB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2015-08-12 at 12:28 +0100, Ian Campbell wrote: > On Wed, 2015-08-12 at 13:03 +0200, Benjamin Beier wrote: > > You never get any output apart from "segmentation fault". > > If you create exactly the same cpupool without using a config file it= =20 > > works absolutely fine. > > Tested on multiple systems and it seems to be reproducible for everyone= . > > STrace shows that the command fails right after reading the content of= =20 > > the config file. >=20 > Please can you capture a backtrace by running it under gdb. Valgrind migh= t > also have something interesting to say. >=20 Yep, a gdb backtrace would be really helpful. I've 'played' with cpupools quite a bit in the last few months (during the whole Xen 4.6 release cycle), and I don't remember seeing anything like this... :-/ > FWIW this doesn't happen on the current development branch: > # cat foo > Testing > # xl cpupool-create foo > foo:1: config parsing error near `Testing': lexical error > Failed to parse config file: Invalid argument >=20 Just tried with the example cpupool config file, from /etc/xen/cpupool, and it works. I'm also on staging (i.e., 4-6.-rc1): root@Zhaman:~# cat /etc/xen/cpupool =20 #=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D # Configuration setup for 'xm cpupool-create' or 'xl cpupool-create'. # This script sets the parameters used when a cpupool is created using # 'xm cpupool-create' or 'xl cpupool-create'. # You use a separate script for each cpupool you want to create, or=20 # you can set the parameters for the cpupool on the xm command line. #=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D # the name of the new cpupool name =3D "Example-Cpupool" # the scheduler to use: valid are e.g. credit, credit2 and rtds sched =3D "credit" # list of cpus to use cpus =3D ["2", "3"] root@Zhaman:~# xl cpupool-create /etc/xen/cpupool cpu 2 illegal or not free root@Zhaman:~# xl cpupool-cpu-remove Pool-0 2,3 root@Zhaman:~# xl cpupool-create /etc/xen/cpupool Using config file "/etc/xen/cpupool" cpupool name: Example-Cpupool scheduler: credit number of cpus: 2 root@Zhaman:~# xl cpupool-list=20 Name CPUs Sched Active Domain count Pool-0 14 credit y 1 Example-Cpupool 2 credit y 0 > But I don't see any obviously related looking fixes in the commit log. >=20 Since 4.5, there has been changes touching both xl and libxl bits of cpupools. E.g.: commit a86eecbbf5155aa5b4ec02b6c5e41baf1a7f49de xl: enable using ranges of pCPUs when creating cpupools However, as I said, I don't remember facing (and fixing) such error. > Was 4.5.0 ok? >=20 > Ian. --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-eca0yVtInnX8fY32J5kB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlXMXNEACgkQk4XaBE3IOsQ97gCeP6lgmkfzACxAHTRvzNlw6Fa3 IQUAn0hUYsxx1aCcx/y42RiERctVR9kA =Yhyi -----END PGP SIGNATURE----- --=-eca0yVtInnX8fY32J5kB-- --===============0311743768839065777== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0311743768839065777==--