From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH OSSTEST v2 3/7] ts-debian-di-install: Install pv-grub-menu in ARM guests, always.
Date: Thu, 13 Aug 2015 17:52:37 +0100 [thread overview]
Message-ID: <1439484761-13511-3-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1439484752.23981.124.camel@citrix.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v2: s/pv-menu-lst/pv-grub-menu/
Add note that pvgrub == grub1
Ungarble a comment
---
ts-debian-di-install | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/ts-debian-di-install b/ts-debian-di-install
index 612e0fa..eef4681 100755
--- a/ts-debian-di-install
+++ b/ts-debian-di-install
@@ -190,9 +190,20 @@ END
$method_cfg = setup_netboot($tmpdir, $arch, $suite);
+ # We need the pv-grub-menu package:
+ # - On x86 when running pvgrub, since pvgrub only speaks grub1
+ # menu.lst syntax and grub2 is now the only grub in
+ # Debian.
+ # - On ARM, which uses pygrub, because grub2 is not installed
+ # on ARM by default (except for, maybe, UEFI guests in the
+ # future, but not today).
+ #
+ # NB: "pvgrub" is grub1/grub-legacy, not PV grub2.
+ my $pvmenulst = ($bl eq "pvgrub" || $arch =~ /arm/);
+
$ps_url = preseed_create_guest($gho, $arch, '',
Suite=>$suite,
- PvMenuLst=>($bl eq "pvgrub"));
+ PvMenuLst=>$pvmenulst);
$extra_disk = "";
}
--
2.1.4
next prev parent reply other threads:[~2015-08-13 16:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 16:52 [PATCH OSSTEST v2 0/7] Fixes for distros-debian-* flights on armhf Ian Campbell
2015-08-13 16:52 ` [PATCH OSSTEST v2 1/7] ts-logs-capture: Collect /var/log/xen/bootloader.*.log Ian Campbell
2015-08-13 16:52 ` [PATCH OSSTEST v2 2/7] ts-debian-di-install: Use exit/poweroff in preference to exit/always_halt Ian Campbell
2015-08-13 16:52 ` Ian Campbell [this message]
2015-08-13 18:02 ` [PATCH OSSTEST v2 3/7] ts-debian-di-install: Install pv-grub-menu in ARM guests, always Ian Jackson
2015-08-13 16:52 ` [PATCH OSSTEST v2 4/7] ts-debian-di-install: Use the suite in the default hostname Ian Campbell
2015-08-13 18:10 ` Ian Jackson
2015-08-13 16:52 ` [PATCH OSSTEST v2 5/7] Debian: ARM: only apply no bootloader workaround if xopts{PvMenuLst} Ian Campbell
2015-08-13 18:02 ` Ian Jackson
2015-08-13 16:52 ` [PATCH OSSTEST v2 6/7] Debian: ARM has no bootloader (for Xen) even in Stretch Ian Campbell
2015-08-13 16:52 ` [PATCH OSSTEST v2 7/7] Debian: Create /boot/boot -> . symlink on ARM when PvMenuLst enabled Ian Campbell
2015-08-21 9:07 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439484761-13511-3-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).