From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.6 v2 1/3] xl: fix vNUMA vdistance parsing Date: Sun, 16 Aug 2015 09:46:42 +0100 Message-ID: <1439714802.3480.9.camel@citrix.com> References: <1439480480-20939-1-git-send-email-wei.liu2@citrix.com> <1439480480-20939-2-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZQtaa-0003C2-9D for xen-devel@lists.xenproject.org; Sun, 16 Aug 2015 08:46:48 +0000 In-Reply-To: <1439480480-20939-2-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Dario Faggioli , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Thu, 2015-08-13 at 16:41 +0100, Wei Liu wrote: > We should parse the output from splitting function, not the original > string. What is the previous incorrect behaviour in practice? It is useful to say this so that when someone comes along and says I'm seeing strange behaviour $FOO there is some chance of either remembering this or spotting it in the commit message. It would also inform my opinion as to whether/why this change is correct. > > Signed-off-by: Wei Liu > Reviewed-by: Dario Faggioli > --- > tools/libxl/xl_cmdimpl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index 499a05c..078acd1 100644 > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -1188,7 +1188,7 @@ static void parse_vnuma_config(const XLU_Config > *config, > len = libxl_string_list_length(&vdist); > > for (j = 0; j < len; j++) { > - val = parse_ulong(value); > + val = parse_ulong(vdist[j]); > p->distances[j] = val; > } > libxl_string_list_dispose(&vdist);