From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for-4.6 v2 3/3] libxc: fix vNUMA memory
	allocation
Date: Sun, 16 Aug 2015 09:47:15 +0100
Message-ID: <1439714835.3480.10.camel@citrix.com>
References: <1439480480-20939-1-git-send-email-wei.liu2@citrix.com>
	<1439480480-20939-4-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=663930937=Ian.Campbell@citrix.com>)
	id 1ZQtb6-0003Dd-8K
	for xen-devel@lists.xenproject.org; Sun, 16 Aug 2015 08:47:20 +0000
In-Reply-To: <1439480480-20939-4-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-08-13 at 16:41 +0100, Wei Liu wrote:
> We should use new_memflags in xc_domain_populate_physmap. That 
> variable
> contains node information.

Same question as v1.

> 
> Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
> ---
>  tools/libxc/xc_hvm_build_x86.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libxc/xc_hvm_build_x86.c 
> b/tools/libxc/xc_hvm_build_x86.c
> index ec11f15..ea250dd 100644
> --- a/tools/libxc/xc_hvm_build_x86.c
> +++ b/tools/libxc/xc_hvm_build_x86.c
> @@ -486,7 +486,8 @@ static int setup_guest(xc_interface *xch,
>  
>                  done = xc_domain_populate_physmap(xch, dom, 
> nr_extents,
>                                                   
>  SUPERPAGE_1GB_SHIFT,
> -                                                  memflags, 
> sp_extents);
> +                                                  new_memflags,
> +                                                  sp_extents);
>  
>                  if ( done > 0 )
>                  {
> @@ -526,7 +527,8 @@ static int setup_guest(xc_interface *xch,
>  
>                      done = xc_domain_populate_physmap(xch, dom, 
> nr_extents,
>                                                       
>  SUPERPAGE_2MB_SHIFT,
> -                                                      memflags, 
> sp_extents);
> +                                                      new_memflags,
> +                                                      sp_extents);
>  
>                      if ( done > 0 )
>                      {