From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH for-4.6 v3 1/3] xl: fix vNUMA vdistance parsing
Date: Mon, 17 Aug 2015 19:56:59 +0100 [thread overview]
Message-ID: <1439837821-8930-2-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1439837821-8930-1-git-send-email-wei.liu2@citrix.com>
We should parse the output from splitting function, not the original
string, otherwise the parsed result is wrong.
For example:
vnuma = [ [...,"vdistance=10,20",...],
[...,"vdistance=20,10",...] ]
Before this change, vdistance from node 0 to all nodes (including
itself) was 10 and vdistance from node 1 to all nodes was 20.
After this change, vdistance from node 0 to itself is 10, to node 1 is
20 and vdistance from node 1 to node 0 is 20, to itself is 10. That's
the correct vdistance settings we expect.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
---
v3: better commit message
---
tools/libxl/xl_cmdimpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index c6b0b68..44fff82 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -1188,7 +1188,7 @@ static void parse_vnuma_config(const XLU_Config *config,
len = libxl_string_list_length(&vdist);
for (j = 0; j < len; j++) {
- val = parse_ulong(value);
+ val = parse_ulong(vdist[j]);
p->distances[j] = val;
}
libxl_string_list_dispose(&vdist);
--
2.1.4
next prev parent reply other threads:[~2015-08-17 18:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 18:56 [PATCH for-4.6 v3 0/3] More vNUMA fixes Wei Liu
2015-08-17 18:56 ` Wei Liu [this message]
2015-08-20 9:04 ` [PATCH for-4.6 v3 1/3] xl: fix vNUMA vdistance parsing Ian Campbell
2015-08-17 18:57 ` [PATCH for-4.6 v3 2/3] xl: error out if vNUMA specifies more vcpus than pcpus Wei Liu
2015-08-20 9:47 ` Ian Campbell
2015-08-17 18:57 ` [PATCH for-4.6 v3 3/3] libxc: fix vNUMA memory allocation Wei Liu
2015-08-20 9:47 ` Ian Campbell
2015-08-21 8:07 ` [PATCH for-4.6 v3 0/3] More vNUMA fixes Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439837821-8930-2-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).