xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Feng Wu <feng.wu@intel.com>
To: xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>, Feng Wu <feng.wu@intel.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v6 02/18] Add cmpxchg16b support for x86-64
Date: Tue, 25 Aug 2015 09:57:41 +0800	[thread overview]
Message-ID: <1440467877-5116-3-git-send-email-feng.wu@intel.com> (raw)
In-Reply-To: <1440467877-5116-1-git-send-email-feng.wu@intel.com>

This patch adds cmpxchg16b support for x86-64, so software
can perform 128-bit atomic write/read.

CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Feng Wu <feng.wu@intel.com>
---
v6:
- Fix a typo

v5:
- Change back the parameters of __cmpxchg16b() to __uint128_t *
- Remove pointless cast for 'ptr'
- Remove pointless parentheses
- Use A constraint for the output

v4:
- Use pointer as the parameter of __cmpxchg16b().
- Use gcc's __uint128_t built-in type
- Make the parameters of __cmpxchg16b() void *

v3:
- Newly added.

 xen/include/asm-x86/x86_64/system.h | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/xen/include/asm-x86/x86_64/system.h b/xen/include/asm-x86/x86_64/system.h
index 662813a..e4e959d 100644
--- a/xen/include/asm-x86/x86_64/system.h
+++ b/xen/include/asm-x86/x86_64/system.h
@@ -6,6 +6,34 @@
                                    (unsigned long)(n),sizeof(*(ptr))))
 
 /*
+ * Atomic 16 bytes compare and exchange.  Compare OLD with MEM, if
+ * identical, store NEW in MEM.  Return the initial value in MEM.
+ * Success is indicated by comparing RETURN with OLD.
+ *
+ * This function can only be called when cpu_has_cx16 is true.
+ */
+
+static always_inline __uint128_t __cmpxchg16b(
+    volatile void *ptr, __uint128_t *old, __uint128_t *new)
+{
+    __uint128_t prev;
+    uint64_t new_high = *new >> 64;
+    uint64_t new_low = (uint64_t)*new;
+
+    ASSERT(cpu_has_cx16);
+
+    asm volatile ( "lock; cmpxchg16b %3"
+                   : "=A" (prev)
+                   : "c" (new_high), "b" (new_low), "m" (*__xg(ptr)), "0" (*old)
+                   : "memory" );
+
+    return prev;
+}
+
+#define cmpxchg16b(ptr,o,n)                                             \
+    __cmpxchg16b((ptr), (__uint128_t *)(o), (__uint128_t *)(n))
+
+/*
  * This function causes value _o to be changed to _n at location _p.
  * If this access causes a fault then we return 1, otherwise we return 0.
  * If no fault occurs then _o is updated to the value we saw at _p. If this
-- 
2.1.0

  parent reply	other threads:[~2015-08-25  1:57 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25  1:57 [PATCH v6 00/18] Add VT-d Posted-Interrupts support Feng Wu
2015-08-25  1:57 ` [PATCH v6 01/18] VT-d Posted-intterrupt (PI) design Feng Wu
2015-08-25  1:57 ` Feng Wu [this message]
2015-09-04 14:22   ` [PATCH v6 02/18] Add cmpxchg16b support for x86-64 Jan Beulich
2015-09-06  6:07     ` Wu, Feng
2015-09-06  6:32       ` Wu, Feng
2015-09-07 10:36         ` Jan Beulich
2015-09-08  7:37           ` Wu, Feng
2015-09-08  8:52             ` Jan Beulich
2015-09-08  8:57               ` Wu, Feng
2015-09-08  9:19                 ` Jan Beulich
2015-09-08  9:30                   ` Wu, Feng
2015-09-07 10:34       ` Jan Beulich
2015-09-07 10:39       ` Jan Beulich
2015-09-04 15:12   ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 03/18] iommu: Add iommu_intpost to control VT-d Posted-Interrupts feature Feng Wu
2015-09-04 14:26   ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 04/18] vt-d: VT-d Posted-Interrupts feature detection Feng Wu
2015-09-04 14:31   ` Jan Beulich
2015-09-06  1:49     ` Wu, Feng
2015-09-07 10:43       ` Jan Beulich
2015-09-08  2:35         ` Wu, Feng
2015-09-08  5:18           ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 05/18] vmx: Extend struct pi_desc to support VT-d Posted-Interrupts Feng Wu
2015-09-04 14:32   ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 06/18] vmx: Add some helper functions for Posted-Interrupts Feng Wu
2015-09-04 14:40   ` Jan Beulich
2015-09-06  2:05     ` Wu, Feng
2015-09-07 10:46       ` Jan Beulich
2015-09-08  2:39         ` Wu, Feng
2015-09-08  5:22           ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 07/18] vmx: Initialize VT-d Posted-Interrupts Descriptor Feng Wu
2015-09-04 14:47   ` Jan Beulich
2015-09-06  2:22     ` Wu, Feng
2015-09-07 10:49       ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 08/18] vmx: Suppress posting interrupts when 'SN' is set Feng Wu
2015-09-04 14:53   ` Jan Beulich
2015-09-06  2:33     ` Wu, Feng
2015-09-07 10:51       ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 09/18] VT-d: Remove pointless casts Feng Wu
2015-09-04 14:55   ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 10/18] vt-d: Extend struct iremap_entry to support VT-d Posted-Interrupts Feng Wu
2015-08-25  1:57 ` [PATCH v6 11/18] vt-d: Add API to update IRTE when VT-d PI is used Feng Wu
2015-09-04 15:11   ` Jan Beulich
2015-09-06  5:24     ` Wu, Feng
2015-09-07 10:54       ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 12/18] x86: move some APIC related macros to apicdef.h Feng Wu
2015-09-04 15:15   ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 13/18] Update IRTE according to guest interrupt config changes Feng Wu
2015-09-04 15:59   ` Jan Beulich
2015-09-06  4:54     ` Wu, Feng
2015-09-07 11:03       ` Jan Beulich
2015-09-08  4:47         ` Wu, Feng
2015-09-08  9:02           ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 14/18] vmx: posted-interrupt handling when vCPU is blocked Feng Wu
2015-09-07 11:47   ` Jan Beulich
2015-09-08  8:50     ` Wu, Feng
2015-09-08  9:08       ` Jan Beulich
2015-09-08  9:14         ` Wu, Feng
2015-08-25  1:57 ` [PATCH v6 15/18] vmx: Properly handle notification event when vCPU is running Feng Wu
2015-09-07 12:10   ` Jan Beulich
2015-09-07 13:00     ` Zhang, Yang Z
2015-09-07 13:12       ` Jan Beulich
2015-09-08  1:38         ` Zhang, Yang Z
2015-09-08  8:57           ` Jan Beulich
2015-09-08  5:18     ` Wu, Feng
2015-09-08  9:13       ` Jan Beulich
2015-09-08  9:23         ` Wu, Feng
2015-09-08  9:31           ` Jan Beulich
2015-09-08  9:36             ` Wu, Feng
2015-09-08 10:13               ` Jan Beulich
2015-09-08 10:15                 ` Wu, Feng
2015-08-25  1:57 ` [PATCH v6 16/18] vmx: Add some scheduler hooks for VT-d posted interrupts Feng Wu
2015-09-07 12:54   ` Jan Beulich
2015-09-09  8:56     ` Wu, Feng
2015-09-09 10:26       ` Jan Beulich
2015-09-10  2:07         ` Wu, Feng
2015-09-10  8:27           ` Jan Beulich
2015-09-10  8:59             ` Wu, Feng
2015-09-10  9:26               ` Jan Beulich
2015-09-10  9:41                 ` Wu, Feng
2015-09-10 10:01                   ` Jan Beulich
2015-09-10 12:34                     ` Wu, Feng
2015-09-10 12:44                       ` Jan Beulich
2015-09-10 12:58                         ` Wu, Feng
2015-09-10 13:15                           ` Jan Beulich
2015-09-10 13:27                             ` Wu, Feng
2015-09-10 14:01                               ` Jan Beulich
2015-09-16  8:56                 ` Wu, Feng
2015-09-16 17:08               ` George Dunlap
2015-09-17  6:26                 ` Wu, Feng
2015-09-16 16:56     ` George Dunlap
2015-09-17  6:15       ` Wu, Feng
2015-09-21  8:23       ` Jan Beulich
2015-09-21  9:28         ` George Dunlap
2015-09-21 11:56           ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 17/18] VT-d: Dump the posted format IRTE Feng Wu
2015-09-07 13:04   ` Jan Beulich
2015-09-08  5:38     ` Wu, Feng
2015-09-08  9:16       ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 18/18] Add a command line parameter for VT-d posted-interrupts Feng Wu
2015-09-07 13:05   ` Jan Beulich
2015-09-01  5:13 ` [PATCH v6 00/18] Add VT-d Posted-Interrupts support Wu, Feng
2015-09-01  5:20   ` Jan Beulich
2015-09-01  5:32     ` Wu, Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440467877-5116-3-git-send-email-feng.wu@intel.com \
    --to=feng.wu@intel.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).