xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Feng Wu <feng.wu@intel.com>
To: xen-devel@lists.xen.org
Cc: Yang Zhang <yang.z.zhang@intel.com>,
	Kevin Tian <kevin.tian@intel.com>, Feng Wu <feng.wu@intel.com>
Subject: [PATCH v6 04/18] vt-d: VT-d Posted-Interrupts feature detection
Date: Tue, 25 Aug 2015 09:57:43 +0800	[thread overview]
Message-ID: <1440467877-5116-5-git-send-email-feng.wu@intel.com> (raw)
In-Reply-To: <1440467877-5116-1-git-send-email-feng.wu@intel.com>

VT-d Posted-Interrupts is an enhancement to CPU side Posted-Interrupt.
With VT-d Posted-Interrupts enabled, external interrupts from
direct-assigned devices can be delivered to guests without VMM
intervention when guest is running in non-root mode.

CC: Yang Zhang <yang.z.zhang@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
Signed-off-by: Feng Wu <feng.wu@intel.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
v5:
- Remove blank line

v4:
- Correct a logic error when setting iommu_intpost to 0

v3:
- Remove the "if no intremap then no intpost" logic in
  intel_vtd_setup(), it is covered in the iommu_setup().
- Add "if no intremap then no intpost" logic in the end
  of init_vtd_hw() which is called by vtd_resume().

So the logic exists in the following three places:
- parse_iommu_param()
- iommu_setup()
- init_vtd_hw()

 xen/drivers/passthrough/vtd/iommu.c | 17 +++++++++++++++--
 xen/drivers/passthrough/vtd/iommu.h |  1 +
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 1dffc40..52c7cc9 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -2079,6 +2079,9 @@ static int init_vtd_hw(void)
                 disable_intremap(drhd->iommu);
     }
 
+    if ( !iommu_intremap )
+        iommu_intpost = 0;
+
     /*
      * Set root entries for each VT-d engine.  After set root entry,
      * must globally invalidate context cache, and then globally
@@ -2147,8 +2150,8 @@ int __init intel_vtd_setup(void)
     }
 
     /* We enable the following features only if they are supported by all VT-d
-     * engines: Snoop Control, DMA passthrough, Queued Invalidation and
-     * Interrupt Remapping.
+     * engines: Snoop Control, DMA passthrough, Queued Invalidation, Interrupt
+     * Remapping, and Posted Interrupt
      */
     for_each_drhd_unit ( drhd )
     {
@@ -2176,6 +2179,14 @@ int __init intel_vtd_setup(void)
         if ( iommu_intremap && !ecap_intr_remap(iommu->ecap) )
             iommu_intremap = 0;
 
+        /*
+         * We cannot use posted interrupt if X86_FEATURE_CX16 is
+         * not supported, since we count on this feature to
+         * atomically update 16-byte IRTE in posted format.
+         */
+        if ( !iommu_intremap || !cap_intr_post(iommu->cap) || !cpu_has_cx16 )
+            iommu_intpost = 0;
+
         if ( !vtd_ept_page_compatible(iommu) )
             iommu_hap_pt_share = 0;
 
@@ -2201,6 +2212,7 @@ int __init intel_vtd_setup(void)
     P(iommu_passthrough, "Dom0 DMA Passthrough");
     P(iommu_qinval, "Queued Invalidation");
     P(iommu_intremap, "Interrupt Remapping");
+    P(iommu_intpost, "Posted Interrupt");
     P(iommu_hap_pt_share, "Shared EPT tables");
 #undef P
 
@@ -2220,6 +2232,7 @@ int __init intel_vtd_setup(void)
     iommu_passthrough = 0;
     iommu_qinval = 0;
     iommu_intremap = 0;
+    iommu_intpost = 0;
     return ret;
 }
 
diff --git a/xen/drivers/passthrough/vtd/iommu.h b/xen/drivers/passthrough/vtd/iommu.h
index ac71ed1..22abefe 100644
--- a/xen/drivers/passthrough/vtd/iommu.h
+++ b/xen/drivers/passthrough/vtd/iommu.h
@@ -61,6 +61,7 @@
 /*
  * Decoding Capability Register
  */
+#define cap_intr_post(c)       (((c) >> 59) & 1)
 #define cap_read_drain(c)      (((c) >> 55) & 1)
 #define cap_write_drain(c)     (((c) >> 54) & 1)
 #define cap_max_amask_val(c)   (((c) >> 48) & 0x3f)
-- 
2.1.0

  parent reply	other threads:[~2015-08-25  1:57 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25  1:57 [PATCH v6 00/18] Add VT-d Posted-Interrupts support Feng Wu
2015-08-25  1:57 ` [PATCH v6 01/18] VT-d Posted-intterrupt (PI) design Feng Wu
2015-08-25  1:57 ` [PATCH v6 02/18] Add cmpxchg16b support for x86-64 Feng Wu
2015-09-04 14:22   ` Jan Beulich
2015-09-06  6:07     ` Wu, Feng
2015-09-06  6:32       ` Wu, Feng
2015-09-07 10:36         ` Jan Beulich
2015-09-08  7:37           ` Wu, Feng
2015-09-08  8:52             ` Jan Beulich
2015-09-08  8:57               ` Wu, Feng
2015-09-08  9:19                 ` Jan Beulich
2015-09-08  9:30                   ` Wu, Feng
2015-09-07 10:34       ` Jan Beulich
2015-09-07 10:39       ` Jan Beulich
2015-09-04 15:12   ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 03/18] iommu: Add iommu_intpost to control VT-d Posted-Interrupts feature Feng Wu
2015-09-04 14:26   ` Jan Beulich
2015-08-25  1:57 ` Feng Wu [this message]
2015-09-04 14:31   ` [PATCH v6 04/18] vt-d: VT-d Posted-Interrupts feature detection Jan Beulich
2015-09-06  1:49     ` Wu, Feng
2015-09-07 10:43       ` Jan Beulich
2015-09-08  2:35         ` Wu, Feng
2015-09-08  5:18           ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 05/18] vmx: Extend struct pi_desc to support VT-d Posted-Interrupts Feng Wu
2015-09-04 14:32   ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 06/18] vmx: Add some helper functions for Posted-Interrupts Feng Wu
2015-09-04 14:40   ` Jan Beulich
2015-09-06  2:05     ` Wu, Feng
2015-09-07 10:46       ` Jan Beulich
2015-09-08  2:39         ` Wu, Feng
2015-09-08  5:22           ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 07/18] vmx: Initialize VT-d Posted-Interrupts Descriptor Feng Wu
2015-09-04 14:47   ` Jan Beulich
2015-09-06  2:22     ` Wu, Feng
2015-09-07 10:49       ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 08/18] vmx: Suppress posting interrupts when 'SN' is set Feng Wu
2015-09-04 14:53   ` Jan Beulich
2015-09-06  2:33     ` Wu, Feng
2015-09-07 10:51       ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 09/18] VT-d: Remove pointless casts Feng Wu
2015-09-04 14:55   ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 10/18] vt-d: Extend struct iremap_entry to support VT-d Posted-Interrupts Feng Wu
2015-08-25  1:57 ` [PATCH v6 11/18] vt-d: Add API to update IRTE when VT-d PI is used Feng Wu
2015-09-04 15:11   ` Jan Beulich
2015-09-06  5:24     ` Wu, Feng
2015-09-07 10:54       ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 12/18] x86: move some APIC related macros to apicdef.h Feng Wu
2015-09-04 15:15   ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 13/18] Update IRTE according to guest interrupt config changes Feng Wu
2015-09-04 15:59   ` Jan Beulich
2015-09-06  4:54     ` Wu, Feng
2015-09-07 11:03       ` Jan Beulich
2015-09-08  4:47         ` Wu, Feng
2015-09-08  9:02           ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 14/18] vmx: posted-interrupt handling when vCPU is blocked Feng Wu
2015-09-07 11:47   ` Jan Beulich
2015-09-08  8:50     ` Wu, Feng
2015-09-08  9:08       ` Jan Beulich
2015-09-08  9:14         ` Wu, Feng
2015-08-25  1:57 ` [PATCH v6 15/18] vmx: Properly handle notification event when vCPU is running Feng Wu
2015-09-07 12:10   ` Jan Beulich
2015-09-07 13:00     ` Zhang, Yang Z
2015-09-07 13:12       ` Jan Beulich
2015-09-08  1:38         ` Zhang, Yang Z
2015-09-08  8:57           ` Jan Beulich
2015-09-08  5:18     ` Wu, Feng
2015-09-08  9:13       ` Jan Beulich
2015-09-08  9:23         ` Wu, Feng
2015-09-08  9:31           ` Jan Beulich
2015-09-08  9:36             ` Wu, Feng
2015-09-08 10:13               ` Jan Beulich
2015-09-08 10:15                 ` Wu, Feng
2015-08-25  1:57 ` [PATCH v6 16/18] vmx: Add some scheduler hooks for VT-d posted interrupts Feng Wu
2015-09-07 12:54   ` Jan Beulich
2015-09-09  8:56     ` Wu, Feng
2015-09-09 10:26       ` Jan Beulich
2015-09-10  2:07         ` Wu, Feng
2015-09-10  8:27           ` Jan Beulich
2015-09-10  8:59             ` Wu, Feng
2015-09-10  9:26               ` Jan Beulich
2015-09-10  9:41                 ` Wu, Feng
2015-09-10 10:01                   ` Jan Beulich
2015-09-10 12:34                     ` Wu, Feng
2015-09-10 12:44                       ` Jan Beulich
2015-09-10 12:58                         ` Wu, Feng
2015-09-10 13:15                           ` Jan Beulich
2015-09-10 13:27                             ` Wu, Feng
2015-09-10 14:01                               ` Jan Beulich
2015-09-16  8:56                 ` Wu, Feng
2015-09-16 17:08               ` George Dunlap
2015-09-17  6:26                 ` Wu, Feng
2015-09-16 16:56     ` George Dunlap
2015-09-17  6:15       ` Wu, Feng
2015-09-21  8:23       ` Jan Beulich
2015-09-21  9:28         ` George Dunlap
2015-09-21 11:56           ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 17/18] VT-d: Dump the posted format IRTE Feng Wu
2015-09-07 13:04   ` Jan Beulich
2015-09-08  5:38     ` Wu, Feng
2015-09-08  9:16       ` Jan Beulich
2015-08-25  1:57 ` [PATCH v6 18/18] Add a command line parameter for VT-d posted-interrupts Feng Wu
2015-09-07 13:05   ` Jan Beulich
2015-09-01  5:13 ` [PATCH v6 00/18] Add VT-d Posted-Interrupts support Wu, Feng
2015-09-01  5:20   ` Jan Beulich
2015-09-01  5:32     ` Wu, Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440467877-5116-5-git-send-email-feng.wu@intel.com \
    --to=feng.wu@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).