xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 4/6] Other-revision-jobs: Update sg-report-flight and -job-history
Date: Fri, 28 Aug 2015 17:33:59 +0100	[thread overview]
Message-ID: <1440779641-22477-4-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1440779641-22477-1-git-send-email-ian.jackson@eu.citrix.com>

We need adjust only the regression analysis.

The other occurrences of special treatment for revision fields are for
reporting output, and are in the context of a specific job.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 sg-report-flight      |    4 ++++
 sg-report-job-history |    1 +
 2 files changed, 5 insertions(+)

diff --git a/sg-report-flight b/sg-report-flight
index 78c91da..a88379a 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -211,6 +211,7 @@ END
             SELECT flight, job, val FROM runvars
                 WHERE flight=?
 		  AND name=?
+                  AND ${\ main_revision_job_cond('job') }
 		GROUP BY flight, job, val
 END
     $revisionsq= db_prepare($revisionsq);
@@ -455,6 +456,9 @@ END
                   AND name like 'built_revision_%'
                 ORDER BY name
 END
+        # We report in jobtext revisions in non-main-revision jobs, too.
+        # (Although, at the time of writing this comment, the jobtexts
+        # seem not to ever be printed in the report...)
         $revh->execute();
         while (my $r= $revh->fetchrow_hashref()) {
             my $br= $r->{name};
diff --git a/sg-report-job-history b/sg-report-job-history
index 9a6e17b..0e2a3f9 100755
--- a/sg-report-job-history
+++ b/sg-report-job-history
@@ -93,6 +93,7 @@ our $revisionsq= db_prepare(<<END);
          WHERE flight=? AND job=?
            AND name LIKE E'built\\_revision\\_\%'
 END
+# (We report on non-main-revision jobs just as for main-revision ones.)
 
 sub add_revisions ($$$$) {
     my ($revmap, $flightnum, $j, $sfx) = @_;
-- 
1.7.10.4

  parent reply	other threads:[~2015-08-28 16:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28 16:33 [OSSTEST PATCH 1/6] Other-revision-jobs: Provide central test Ian Jackson
2015-08-28 16:33 ` [OSSTEST PATCH 2/6] Other-revision-jobs: Update report__find_test Ian Jackson
2015-08-28 16:33 ` [OSSTEST PATCH 3/6] Other-revision-jobs: Update sg-check-tested Ian Jackson
2015-08-28 16:33 ` Ian Jackson [this message]
2015-08-28 16:34 ` [OSSTEST PATCH 5/6] Other-revision-jobs: Provide other_revision_job_suffix Ian Jackson
2015-08-28 16:34 ` [OSSTEST PATCH 6/6] Other-revision-jobs: Update cs-bisection-step Ian Jackson
2015-08-28 16:36 ` [OSSTEST PATCH 1/6] Other-revision-jobs: Provide central test Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440779641-22477-4-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).