From: Ian Campbell <ian.campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Lars Kurth <lars.kurth.xen@gmail.com>
Cc: xen devel <xen-devel@lists.xenproject.org>
Subject: Re: [xen 4.6 retrospective] [bad] Code style checking takes up too much time
Date: Tue, 1 Sep 2015 15:47:30 +0100 [thread overview]
Message-ID: <1441118850.26292.43.camel@citrix.com> (raw)
In-Reply-To: <55E45584.2070204@citrix.com>
On Mon, 2015-08-31 at 14:24 +0100, Andrew Cooper wrote:
> On 31/08/15 08:27, Jan Beulich wrote:
> > > > > On 28.08.15 at 17:39, <lars.kurth.xen@gmail.com> wrote:
> > > What may be a bigger issue, is that older code may not fully adhere
> > > to
> > > coding standards. The open question is then
> > > * Whether such a tool should only run on the diff/patch
> > Isn't that the intended / expected behavior of such a tool anyway?
>
> I would have thought so, and moreso only on the newly added lines.
That's what Linux's checkpatch.pl does, I think.
prev parent reply other threads:[~2015-09-01 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 15:39 [xen 4.6 retrospective] [bad] Code style checking takes up too much time Lars Kurth
2015-08-31 7:27 ` Jan Beulich
2015-08-31 13:24 ` Andrew Cooper
2015-09-01 14:47 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441118850.26292.43.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=lars.kurth.xen@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).