From: Ian Campbell <ian.campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH v2 2/2] xen/arm: support gzip compressed kernels
Date: Tue, 1 Sep 2015 16:07:07 +0100 [thread overview]
Message-ID: <1441120027.26292.51.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1509011507280.2672@kaball.uk.xensource.com>
On Tue, 2015-09-01 at 15:57 +0100, Stefano Stabellini wrote:
>
> > I'm not sure to see how this would work. Any call to
> > alloc_xenheap_pages
> > should be follow by a called to free_xenheap_pages.
> > But when freeing the modules, we are using init_heap_pages.
> > I don't think they are similar.
>
> Actually init_heap_pages is just a wrapper around free_heap_pages, like
> free_xenheap_pages. I think it is safe to call init_heap_pages, on
> memory allocated by alloc_xenheap_pages.
That probably depends on lots of things, in particular the setting of
CONFIG_SEPARATE_XENHEAP and in any case I think it should be avoided as a
matter of principal.
Also, modules are freed to the domheap not the xenheap.
Maybe it would be best if this memory was allocated from there?
Ian.
next prev parent reply other threads:[~2015-09-01 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 11:19 [PATCH v2 0/2] support gzipped kernels on arm Stefano Stabellini
2015-08-13 11:21 ` [PATCH v2 1/2] xen: move perform_gunzip to common Stefano Stabellini
2015-08-13 12:21 ` Jan Beulich
2015-09-01 13:56 ` Stefano Stabellini
2015-09-01 14:10 ` Jan Beulich
2015-08-13 11:21 ` [PATCH v2 2/2] xen/arm: support gzip compressed kernels Stefano Stabellini
2015-08-13 11:35 ` Julien Grall
2015-09-01 14:57 ` Stefano Stabellini
2015-09-01 15:07 ` Ian Campbell [this message]
2015-09-02 11:26 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441120027.26292.51.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).