From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for 4.6] tools: Honor Config.mk debug value,
 rather than setting our own
Date: Wed, 2 Sep 2015 14:27:27 +0100
Message-ID: <1441200447.26292.191.camel@citrix.com>
References: <1441186495-7256-1-git-send-email-george.dunlap@eu.citrix.com>
	<20150902110822.GE18474@zion.uk.xensource.com>
	<1441193071.26292.139.camel@citrix.com>
	<20150902112546.GF18474@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150902112546.GF18474@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@citrix.com>, Roger Pau Monne <roger.pau@citrix.com>, Euan Harris <euan.harris@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-09-02 at 12:25 +0100, Wei Liu wrote:
> On Wed, Sep 02, 2015 at 12:24:31PM +0100, Ian Campbell wrote:
> > On Wed, 2015-09-02 at 12:08 +0100, Wei Liu wrote:
> > > On Wed, Sep 02, 2015 at 10:34:55AM +0100, George Dunlap wrote:
> > > > Changeset 1166ecf ('tools/Rules.mk: Don't optimize debug builds; 
> > > > add
> > > > macro debugging information') exposed a bug whereby the autoconf 
> > > > stuff
> > > > in tools was setting its own debug value (defaulting to ENABLED, 
> > > > even
> > > > for releases) instead of honoring the value set in Config.mk.
> > > > 
> > > > After that changeset, if the global build has -D_FORTIFY_SOURCE
> > > > enabled (as is the default in CentOS 7 rpmbuild), then the tools 
> > > > build
> > > > will fail (because debug builds default to on).
> > > > 
> > > > There should be only one place to specify whether to build debug or
> > > > not, and Config.mk is already included by the relevant makefiles. 
> > > >  So
> > > > simply remove the tools/configure debug option and everything falls
> > > > into place naturally.
> > > > 
> > > > Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
> > > 
> > > Acked-by: Wei Liu <wei.liu2@citrix.com>
> > 
> > Release-ack too?
> 
> Release-acked-by: Wei Liu <wei.liu2@citrix.com>

Thx, applied.