* [PATCH] build: update top-level make help
@ 2015-09-01 20:10 Doug Goldstein
2015-09-02 8:28 ` Jan Beulich
0 siblings, 1 reply; 11+ messages in thread
From: Doug Goldstein @ 2015-09-01 20:10 UTC (permalink / raw)
To: Ian Campbell, Ian Jackson, Jan Beulich, Keir Fraser, Tim Deegan,
xen-devel
Cc: Doug Goldstein
Update the top-level make help to include all the possible targets and
not reference targets that are deprecated while hopefully being more
clear as to what each target does.
---
Makefile | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index ba0df70..75177f0 100644
--- a/Makefile
+++ b/Makefile
@@ -228,16 +228,23 @@ help:
@echo ' install-stubdom - build and install the stubdomain images'
@echo ' install-docs - build and install user documentation'
@echo ''
- @echo 'Building targets:'
+ @echo 'Local dist targets:'
@echo ' dist - build and install everything into local dist directory'
@echo ' world - clean everything then make dist'
- @echo ' xen - build and install Xen hypervisor'
- @echo ' tools - build and install tools'
- @echo ' stubdom - build and install the stubdomain images'
- @echo ' docs - build and install user documentation'
+ @echo ' dist-xen - build Xen hypervisor and install into local dist'
+ @echo ' dist-tools - build the tools and install into local dist'
+ @echo ' dist-stubdom - build the stubdomain images and install into local dist'
+ @echo ' dist-docs - build user documentation and install into local dist'
+ @echo ''
+ @echo 'Building targets:'
+ @echo ' build - build everything'
+ @echo ' build-xen - build Xen hypervisor'
+ @echo ' build-tools - build the tools'
+ @echo ' build-stubdom - build the stubdomain images'
+ @echo ' build-docs - build user documentation'
@echo ''
@echo 'Cleaning targets:'
- @echo ' clean - clean the Xen, tools and docs (but not guest kernel trees)'
+ @echo ' clean - clean the Xen, tools and docs'
@echo ' distclean - clean plus delete kernel build trees and'
@echo ' local downloaded files'
@echo ' subtree-force-update - Call *-force-update on all git subtrees (qemu, seabios, ovmf)'
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] build: update top-level make help
2015-09-01 20:10 [PATCH] build: update top-level make help Doug Goldstein
@ 2015-09-02 8:28 ` Jan Beulich
2015-09-02 13:09 ` Doug Goldstein
0 siblings, 1 reply; 11+ messages in thread
From: Jan Beulich @ 2015-09-02 8:28 UTC (permalink / raw)
To: cardoe; +Cc: keir, tim, ian.jackson, ian.campbell, xen-devel
>>> Doug Goldstein <cardoe@cardoe.com> 09/01/15 10:10 PM >>>
>Update the top-level make help to include all the possible targets and
>not reference targets that are deprecated while hopefully being more
>clear as to what each target does.
>---
Missing Signed-off-by:.
>--- a/Makefile
>+++ b/Makefile
>@@ -228,16 +228,23 @@ help:
>@echo ' install-stubdom - build and install the stubdomain images'
>@echo ' install-docs - build and install user documentation'
>@echo ''
>- @echo 'Building targets:'
>+ @echo 'Local dist targets:'
>@echo ' dist - build and install everything into local dist directory'
>@echo ' world - clean everything then make dist'
>- @echo ' xen - build and install Xen hypervisor'
>- @echo ' tools - build and install tools'
>- @echo ' stubdom - build and install the stubdomain images'
>- @echo ' docs - build and install user documentation'
Why are these being removed? At least the xen and tools ones work fine for me.
Jan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] build: update top-level make help
2015-09-02 8:28 ` Jan Beulich
@ 2015-09-02 13:09 ` Doug Goldstein
2015-09-02 13:14 ` Jan Beulich
0 siblings, 1 reply; 11+ messages in thread
From: Doug Goldstein @ 2015-09-02 13:09 UTC (permalink / raw)
To: Jan Beulich; +Cc: Keir Fraser, Tim Deegan, Ian Jackson, Ian Campbell, xen-devel
On Wed, Sep 2, 2015 at 3:28 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>>> Doug Goldstein <cardoe@cardoe.com> 09/01/15 10:10 PM >>>
>>Update the top-level make help to include all the possible targets and
>>not reference targets that are deprecated while hopefully being more
>>clear as to what each target does.
>>---
>
> Missing Signed-off-by:.
>
Apologies. I forgot. Do I need to resubmit or can I just say on this email:
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>>--- a/Makefile
>>+++ b/Makefile
>>@@ -228,16 +228,23 @@ help:
>>@echo ' install-stubdom - build and install the stubdomain images'
>>@echo ' install-docs - build and install user documentation'
>>@echo ''
>>- @echo 'Building targets:'
>>+ @echo 'Local dist targets:'
>>@echo ' dist - build and install everything into local dist directory'
>>@echo ' world - clean everything then make dist'
>>- @echo ' xen - build and install Xen hypervisor'
>>- @echo ' tools - build and install tools'
>>- @echo ' stubdom - build and install the stubdomain images'
>>- @echo ' docs - build and install user documentation'
>
> Why are these being removed? At least the xen and tools ones work fine for me.
>
> Jan
>
In the makefile they're marked as "legacy" and they are wired straight
to their "dist-" equivalents.
--
Doug Goldstein
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] build: update top-level make help
2015-09-02 13:09 ` Doug Goldstein
@ 2015-09-02 13:14 ` Jan Beulich
2015-09-02 13:34 ` Ian Campbell
0 siblings, 1 reply; 11+ messages in thread
From: Jan Beulich @ 2015-09-02 13:14 UTC (permalink / raw)
To: Doug Goldstein
Cc: Keir Fraser, Tim Deegan, Ian Jackson, Ian Campbell, xen-devel
>>> On 02.09.15 at 15:09, <cardoe@cardoe.com> wrote:
> On Wed, Sep 2, 2015 at 3:28 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>>>> Doug Goldstein <cardoe@cardoe.com> 09/01/15 10:10 PM >>>
>>>Update the top-level make help to include all the possible targets and
>>>not reference targets that are deprecated while hopefully being more
>>>clear as to what each target does.
>>>---
>>
>> Missing Signed-off-by:.
>>
>
> Apologies. I forgot. Do I need to resubmit or can I just say on this email:
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Considering that I'd like you to adjust the patch itself, re-submission
will be unavoidable I think.
>>>--- a/Makefile
>>>+++ b/Makefile
>>>@@ -228,16 +228,23 @@ help:
>>>@echo ' install-stubdom - build and install the stubdomain images'
>>>@echo ' install-docs - build and install user documentation'
>>>@echo ''
>>>- @echo 'Building targets:'
>>>+ @echo 'Local dist targets:'
>>>@echo ' dist - build and install everything into local dist directory'
>>>@echo ' world - clean everything then make dist'
>>>- @echo ' xen - build and install Xen hypervisor'
>>>- @echo ' tools - build and install tools'
>>>- @echo ' stubdom - build and install the stubdomain images'
>>>- @echo ' docs - build and install user documentation'
>>
>> Why are these being removed? At least the xen and tools ones work fine for me.
>
> In the makefile they're marked as "legacy" and they are wired straight
> to their "dist-" equivalents.
But still they're there and they work (and they're faster to type than
their "dist-" equivalents).
Jan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] build: update top-level make help
2015-09-02 13:14 ` Jan Beulich
@ 2015-09-02 13:34 ` Ian Campbell
2015-09-02 14:14 ` Jan Beulich
0 siblings, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2015-09-02 13:34 UTC (permalink / raw)
To: Jan Beulich, Doug Goldstein
Cc: Tim Deegan, Keir Fraser, Ian Jackson, xen-devel
On Wed, 2015-09-02 at 07:14 -0600, Jan Beulich wrote:
> >
> > > > On 02.09.15 at 15:09, <cardoe@cardoe.com> wrote:
> > On Wed, Sep 2, 2015 at 3:28 AM, Jan Beulich <jbeulich@suse.com> wrote:
> > > > > > Doug Goldstein <cardoe@cardoe.com> 09/01/15 10:10 PM >>>
> > > > Update the top-level make help to include all the possible targets
> > > > and
> > > > not reference targets that are deprecated while hopefully being
> > > > more
> > > > clear as to what each target does.
> > > > ---
> > >
> > > Missing Signed-off-by:.
> > >
> >
> > Apologies. I forgot. Do I need to resubmit or can I just say on this
> > email:
> >
> > Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>
> Considering that I'd like you to adjust the patch itself, re-submission
> will be unavoidable I think.
>
> > > > --- a/Makefile
> > > > +++ b/Makefile
> > > > @@ -228,16 +228,23 @@ help:
> > > > @echo ' install-stubdom - build and install the stubdomain
> > > > images'
> > > > @echo ' install-docs - build and install user
> > > > documentation'
> > > > @echo ''
> > > > - @echo 'Building targets:'
> > > > + @echo 'Local dist targets:'
> > > > @echo ' dist - build and install everything into
> > > > local dist directory'
> > > > @echo ' world - clean everything then make dist'
> > > > - @echo ' xen - build and install Xen
> > > > hypervisor'
> > > > - @echo ' tools - build and install tools'
> > > > - @echo ' stubdom - build and install the
> > > > stubdomain images'
> > > > - @echo ' docs - build and install user
> > > > documentation'
> > >
> > > Why are these being removed? At least the xen and tools ones work
> > > fine for me.
> >
> > In the makefile they're marked as "legacy" and they are wired straight
> > to their "dist-" equivalents.
>
> But still they're there and they work (and they're faster to type than
> their "dist-" equivalents).
If they are legacy then it is correct to not list them here. You can still
use the legacy interfaces if you want (they aren't being removed) but not
being to be told about them in the help message seems correct to me.
If you think they should not be legacy then that would IMHO need to be a
different patch to remove the "# Legacy dist targets".
As it stands this patch, with the S-o-b above, is IMHO a consistent and
correct change:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
If you would prefer instead to mark those interfaces non-legacy then please
do so.
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] build: update top-level make help
2015-09-02 13:34 ` Ian Campbell
@ 2015-09-02 14:14 ` Jan Beulich
2015-09-02 14:22 ` Doug Goldstein
2015-09-02 14:26 ` Ian Campbell
0 siblings, 2 replies; 11+ messages in thread
From: Jan Beulich @ 2015-09-02 14:14 UTC (permalink / raw)
To: Ian Campbell
Cc: Ian Jackson, Tim Deegan, Keir Fraser, Doug Goldstein, xen-devel
>>> On 02.09.15 at 15:34, <ian.campbell@citrix.com> wrote:
> On Wed, 2015-09-02 at 07:14 -0600, Jan Beulich wrote:
>> > > > On 02.09.15 at 15:09, <cardoe@cardoe.com> wrote:
>> > On Wed, Sep 2, 2015 at 3:28 AM, Jan Beulich <jbeulich@suse.com> wrote:
>> > > > > > Doug Goldstein <cardoe@cardoe.com> 09/01/15 10:10 PM >>>
>> > > > --- a/Makefile
>> > > > +++ b/Makefile
>> > > > @@ -228,16 +228,23 @@ help:
>> > > > @echo ' install-stubdom - build and install the stubdomain
>> > > > images'
>> > > > @echo ' install-docs - build and install user
>> > > > documentation'
>> > > > @echo ''
>> > > > - @echo 'Building targets:'
>> > > > + @echo 'Local dist targets:'
>> > > > @echo ' dist - build and install everything into
>> > > > local dist directory'
>> > > > @echo ' world - clean everything then make dist'
>> > > > - @echo ' xen - build and install Xen
>> > > > hypervisor'
>> > > > - @echo ' tools - build and install tools'
>> > > > - @echo ' stubdom - build and install the
>> > > > stubdomain images'
>> > > > - @echo ' docs - build and install user
>> > > > documentation'
>> > >
>> > > Why are these being removed? At least the xen and tools ones work
>> > > fine for me.
>> >
>> > In the makefile they're marked as "legacy" and they are wired straight
>> > to their "dist-" equivalents.
>>
>> But still they're there and they work (and they're faster to type than
>> their "dist-" equivalents).
>
> If they are legacy then it is correct to not list them here.
Hmm - why does "legacy" imply "not documented here"?
But anyway - I don't mean to stand in the way of you committing the
patch as is, as long as those (legacy) build targets don't go away.
Jan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] build: update top-level make help
2015-09-02 14:14 ` Jan Beulich
@ 2015-09-02 14:22 ` Doug Goldstein
2015-09-02 14:31 ` Ian Campbell
2015-09-02 14:26 ` Ian Campbell
1 sibling, 1 reply; 11+ messages in thread
From: Doug Goldstein @ 2015-09-02 14:22 UTC (permalink / raw)
To: Jan Beulich, Ian Campbell; +Cc: Keir Fraser, Tim Deegan, Ian Jackson, xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 2129 bytes --]
On 9/2/15 9:14 AM, Jan Beulich wrote:
>>>> On 02.09.15 at 15:34, <ian.campbell@citrix.com> wrote:
>> On Wed, 2015-09-02 at 07:14 -0600, Jan Beulich wrote:
>>>>>> On 02.09.15 at 15:09, <cardoe@cardoe.com> wrote:
>>>> On Wed, Sep 2, 2015 at 3:28 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>>>> Doug Goldstein <cardoe@cardoe.com> 09/01/15 10:10 PM >>>
>>>>>> --- a/Makefile
>>>>>> +++ b/Makefile
>>>>>> @@ -228,16 +228,23 @@ help:
>>>>>> @echo ' install-stubdom - build and install the stubdomain
>>>>>> images'
>>>>>> @echo ' install-docs - build and install user
>>>>>> documentation'
>>>>>> @echo ''
>>>>>> - @echo 'Building targets:'
>>>>>> + @echo 'Local dist targets:'
>>>>>> @echo ' dist - build and install everything into
>>>>>> local dist directory'
>>>>>> @echo ' world - clean everything then make dist'
>>>>>> - @echo ' xen - build and install Xen
>>>>>> hypervisor'
>>>>>> - @echo ' tools - build and install tools'
>>>>>> - @echo ' stubdom - build and install the
>>>>>> stubdomain images'
>>>>>> - @echo ' docs - build and install user
>>>>>> documentation'
>>>>>
>>>>> Why are these being removed? At least the xen and tools ones work
>>>>> fine for me.
>>>>
>>>> In the makefile they're marked as "legacy" and they are wired straight
>>>> to their "dist-" equivalents.
>>>
>>> But still they're there and they work (and they're faster to type than
>>> their "dist-" equivalents).
>>
>> If they are legacy then it is correct to not list them here.
>
> Hmm - why does "legacy" imply "not documented here"?
>
> But anyway - I don't mean to stand in the way of you committing the
> patch as is, as long as those (legacy) build targets don't go away.
>
> Jan
>
I definitely had no intention of removing them. I was merely trying to
update the help output to match what I saw when reading the contents of
the Makefile.
Do I still need to resubmit or is my S-o-b on the ML ok?
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] build: update top-level make help
2015-09-02 14:22 ` Doug Goldstein
@ 2015-09-02 14:31 ` Ian Campbell
2015-09-04 14:41 ` Ian Campbell
0 siblings, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2015-09-02 14:31 UTC (permalink / raw)
To: Doug Goldstein, Jan Beulich
Cc: Keir Fraser, Tim Deegan, Ian Jackson, xen-devel
On Wed, 2015-09-02 at 09:22 -0500, Doug Goldstein wrote:
> On 9/2/15 9:14 AM, Jan Beulich wrote:
> > > > > On 02.09.15 at 15:34, <ian.campbell@citrix.com> wrote:
> > > On Wed, 2015-09-02 at 07:14 -0600, Jan Beulich wrote:
> > > > > > > On 02.09.15 at 15:09, <cardoe@cardoe.com> wrote:
> > > > > On Wed, Sep 2, 2015 at 3:28 AM, Jan Beulich <jbeulich@suse.com>
> > > > > wrote:
> > > > > > > > > Doug Goldstein <cardoe@cardoe.com> 09/01/15 10:10 PM >>>
> > > > > > > --- a/Makefile
> > > > > > > +++ b/Makefile
> > > > > > > @@ -228,16 +228,23 @@ help:
> > > > > > > @echo ' install-stubdom - build and install the
> > > > > > > stubdomain
> > > > > > > images'
> > > > > > > @echo ' install-docs - build and install user
> > > > > > > documentation'
> > > > > > > @echo ''
> > > > > > > - @echo 'Building targets:'
> > > > > > > + @echo 'Local dist targets:'
> > > > > > > @echo ' dist - build and install everything
> > > > > > > into
> > > > > > > local dist directory'
> > > > > > > @echo ' world - clean everything then make
> > > > > > > dist'
> > > > > > > - @echo ' xen - build and install Xen
> > > > > > >
> > > > > > > hypervisor'
> > > > > > > - @echo ' tools - build and install
> > > > > > > tools'
> > > > > > > - @echo ' stubdom - build and install the
> > > > > > >
> > > > > > > stubdomain images'
> > > > > > > - @echo ' docs - build and install
> > > > > > > user
> > > > > > > documentation'
> > > > > >
> > > > > > Why are these being removed? At least the xen and tools ones
> > > > > > work
> > > > > > fine for me.
> > > > >
> > > > > In the makefile they're marked as "legacy" and they are wired
> > > > > straight
> > > > > to their "dist-" equivalents.
> > > >
> > > > But still they're there and they work (and they're faster to type
> > > > than
> > > > their "dist-" equivalents).
> > >
> > > If they are legacy then it is correct to not list them here.
> >
> > Hmm - why does "legacy" imply "not documented here"?
> >
> > But anyway - I don't mean to stand in the way of you committing the
> > patch as is, as long as those (legacy) build targets don't go away.
> >
> > Jan
> >
>
> I definitely had no intention of removing them. I was merely trying to
> update the help output to match what I saw when reading the contents of
> the Makefile.
>
> Do I still need to resubmit or is my S-o-b on the ML ok?
A post-facto S-o-b like you did is fine.
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] build: update top-level make help
2015-09-02 14:31 ` Ian Campbell
@ 2015-09-04 14:41 ` Ian Campbell
0 siblings, 0 replies; 11+ messages in thread
From: Ian Campbell @ 2015-09-04 14:41 UTC (permalink / raw)
To: Doug Goldstein, Jan Beulich
Cc: Tim Deegan, Keir Fraser, Ian Jackson, xen-devel
On Wed, 2015-09-02 at 15:31 +0100, Ian Campbell wrote:
> On Wed, 2015-09-02 at 09:22 -0500, Doug Goldstein wrote:
> > On 9/2/15 9:14 AM, Jan Beulich wrote:
> > > > > > On 02.09.15 at 15:34, <ian.campbell@citrix.com> wrote:
> > > > On Wed, 2015-09-02 at 07:14 -0600, Jan Beulich wrote:
> > > > > > > > On 02.09.15 at 15:09, <cardoe@cardoe.com> wrote:
> > > > > > On Wed, Sep 2, 2015 at 3:28 AM, Jan Beulich <jbeulich@suse.com>
> > > > > >
> > > > > > wrote:
> > > > > > > > > > Doug Goldstein <cardoe@cardoe.com> 09/01/15 10:10 PM
> > > > > > > > > > >>>
> > > > > > > > --- a/Makefile
> > > > > > > > +++ b/Makefile
> > > > > > > > @@ -228,16 +228,23 @@ help:
> > > > > > > > @echo ' install-stubdom - build and install the
> > > > > > > > stubdomain
> > > > > > > > images'
> > > > > > > > @echo ' install-docs - build and install user
> > > > > > > > documentation'
> > > > > > > > @echo ''
> > > > > > > > - @echo 'Building targets:'
> > > > > > > > + @echo 'Local dist targets:'
> > > > > > > > @echo ' dist - build and install
> > > > > > > > everything
> > > > > > > > into
> > > > > > > > local dist directory'
> > > > > > > > @echo ' world - clean everything then make
> > > > > > > >
> > > > > > > > dist'
> > > > > > > > - @echo ' xen - build and install
> > > > > > > > Xen
> > > > > > > >
> > > > > > > > hypervisor'
> > > > > > > > - @echo ' tools - build and install
> > > > > > > > tools'
> > > > > > > > - @echo ' stubdom - build and install
> > > > > > > > the
> > > > > > > >
> > > > > > > > stubdomain images'
> > > > > > > > - @echo ' docs - build and install
> > > > > > > > user
> > > > > > > > documentation'
> > > > > > >
> > > > > > > Why are these being removed? At least the xen and tools ones
> > > > > > > work
> > > > > > > fine for me.
> > > > > >
> > > > > > In the makefile they're marked as "legacy" and they are wired
> > > > > > straight
> > > > > > to their "dist-" equivalents.
> > > > >
> > > > > But still they're there and they work (and they're faster to type
> > > > >
> > > > > than
> > > > > their "dist-" equivalents).
> > > >
> > > > If they are legacy then it is correct to not list them here.
> > >
> > > Hmm - why does "legacy" imply "not documented here"?
> > >
> > > But anyway - I don't mean to stand in the way of you committing the
> > > patch as is, as long as those (legacy) build targets don't go away.
> > >
> > > Jan
> > >
> >
> > I definitely had no intention of removing them. I was merely trying to
> > update the help output to match what I saw when reading the contents of
> > the Makefile.
> >
> > Do I still need to resubmit or is my S-o-b on the ML ok?
>
> A post-facto S-o-b like you did is fine.
And now I've applied.
>
> Ian.
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] build: update top-level make help
2015-09-02 14:14 ` Jan Beulich
2015-09-02 14:22 ` Doug Goldstein
@ 2015-09-02 14:26 ` Ian Campbell
2015-09-02 14:55 ` Jan Beulich
1 sibling, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2015-09-02 14:26 UTC (permalink / raw)
To: Jan Beulich
Cc: Ian Jackson, Tim Deegan, Keir Fraser, Doug Goldstein, xen-devel
On Wed, 2015-09-02 at 08:14 -0600, Jan Beulich wrote:
> >
> > > > On 02.09.15 at 15:34, <ian.campbell@citrix.com> wrote:
> > On Wed, 2015-09-02 at 07:14 -0600, Jan Beulich wrote:
> > > > > > On 02.09.15 at 15:09, <cardoe@cardoe.com> wrote:
> > > > On Wed, Sep 2, 2015 at 3:28 AM, Jan Beulich <jbeulich@suse.com>
> > > > wrote:
> > > > > > > > Doug Goldstein <cardoe@cardoe.com> 09/01/15 10:10 PM >>>
> > > > > > --- a/Makefile
> > > > > > +++ b/Makefile
> > > > > > @@ -228,16 +228,23 @@ help:
> > > > > > @echo ' install-stubdom - build and install the
> > > > > > stubdomain
> > > > > > images'
> > > > > > @echo ' install-docs - build and install user
> > > > > > documentation'
> > > > > > @echo ''
> > > > > > - @echo 'Building targets:'
> > > > > > + @echo 'Local dist targets:'
> > > > > > @echo ' dist - build and install everything
> > > > > > into
> > > > > > local dist directory'
> > > > > > @echo ' world - clean everything then make
> > > > > > dist'
> > > > > > - @echo ' xen - build and install Xen
> > > > > > hypervisor'
> > > > > > - @echo ' tools - build and install
> > > > > > tools'
> > > > > > - @echo ' stubdom - build and install the
> > > > > > stubdomain images'
> > > > > > - @echo ' docs - build and install user
> > > > > > documentation'
> > > > >
> > > > > Why are these being removed? At least the xen and tools ones work
> > > > >
> > > > > fine for me.
> > > >
> > > > In the makefile they're marked as "legacy" and they are wired
> > > > straight
> > > > to their "dist-" equivalents.
> > >
> > > But still they're there and they work (and they're faster to type
> > > than
> > > their "dist-" equivalents).
> >
> > If they are legacy then it is correct to not list them here.
>
> Hmm - why does "legacy" imply "not documented here"?
Legacy means "deprecated" and/or "not encouraged", which to me implies we
should direct users to the non-deprecated alternatives, which also serves
to make the list of potential targets in the help less overwhelming.
> But anyway - I don't mean to stand in the way of you committing the
> patch as is, as long as those (legacy) build targets don't go away.
>
> Jan
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] build: update top-level make help
2015-09-02 14:26 ` Ian Campbell
@ 2015-09-02 14:55 ` Jan Beulich
0 siblings, 0 replies; 11+ messages in thread
From: Jan Beulich @ 2015-09-02 14:55 UTC (permalink / raw)
To: Ian Campbell
Cc: Ian Jackson, Tim Deegan, Keir Fraser, Doug Goldstein, xen-devel
>>> On 02.09.15 at 16:26, <ian.campbell@citrix.com> wrote:
> On Wed, 2015-09-02 at 08:14 -0600, Jan Beulich wrote:
>> >
>> > > > On 02.09.15 at 15:34, <ian.campbell@citrix.com> wrote:
>> > On Wed, 2015-09-02 at 07:14 -0600, Jan Beulich wrote:
>> > > > > > On 02.09.15 at 15:09, <cardoe@cardoe.com> wrote:
>> > > > On Wed, Sep 2, 2015 at 3:28 AM, Jan Beulich <jbeulich@suse.com>
>> > > > wrote:
>> > > > > > > > Doug Goldstein <cardoe@cardoe.com> 09/01/15 10:10 PM >>>
>> > > > > > --- a/Makefile
>> > > > > > +++ b/Makefile
>> > > > > > @@ -228,16 +228,23 @@ help:
>> > > > > > @echo ' install-stubdom - build and install the
>> > > > > > stubdomain
>> > > > > > images'
>> > > > > > @echo ' install-docs - build and install user
>> > > > > > documentation'
>> > > > > > @echo ''
>> > > > > > - @echo 'Building targets:'
>> > > > > > + @echo 'Local dist targets:'
>> > > > > > @echo ' dist - build and install everything
>> > > > > > into
>> > > > > > local dist directory'
>> > > > > > @echo ' world - clean everything then make
>> > > > > > dist'
>> > > > > > - @echo ' xen - build and install Xen
>> > > > > > hypervisor'
>> > > > > > - @echo ' tools - build and install
>> > > > > > tools'
>> > > > > > - @echo ' stubdom - build and install the
>> > > > > > stubdomain images'
>> > > > > > - @echo ' docs - build and install user
>> > > > > > documentation'
>> > > > >
>> > > > > Why are these being removed? At least the xen and tools ones work
>> > > > >
>> > > > > fine for me.
>> > > >
>> > > > In the makefile they're marked as "legacy" and they are wired
>> > > > straight
>> > > > to their "dist-" equivalents.
>> > >
>> > > But still they're there and they work (and they're faster to type
>> > > than
>> > > their "dist-" equivalents).
>> >
>> > If they are legacy then it is correct to not list them here.
>>
>> Hmm - why does "legacy" imply "not documented here"?
>
> Legacy means "deprecated" and/or "not encouraged", which to me implies we
> should direct users to the non-deprecated alternatives, which also serves
> to make the list of potential targets in the help less overwhelming.
Interesting - to me "legacy" and "deprecated" are different things
(and the dictionary I have translating both to German seems to
support this pov). Reducing the list of targets, otoh, is something
that perhaps indeed may be helpful.
Jan
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-09-04 14:41 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-01 20:10 [PATCH] build: update top-level make help Doug Goldstein
2015-09-02 8:28 ` Jan Beulich
2015-09-02 13:09 ` Doug Goldstein
2015-09-02 13:14 ` Jan Beulich
2015-09-02 13:34 ` Ian Campbell
2015-09-02 14:14 ` Jan Beulich
2015-09-02 14:22 ` Doug Goldstein
2015-09-02 14:31 ` Ian Campbell
2015-09-04 14:41 ` Ian Campbell
2015-09-02 14:26 ` Ian Campbell
2015-09-02 14:55 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).